PHP Simple Insert Issue

Question

I cannot figure out what the issue is with my PHP but the INSERT function seems to fail at all times. I have the correct table rows listed but there could just be a simple syntax issue. If that code is needed, I can supply it also. Here's my PHP and database structure:

enter image description here

  <?php  
 $con = mysql_connect('***','***','***');  
    if (!$con)  
{  
    echo "Failed to make connection.";  
    exit;  
}  
$db = mysql_select_db('***');  
if (!$db)  
{  
    echo "Failed to select db.";  
    exit;  
}  
$username   = $_POST['username'];  
$password   = $_POST['password'];  
$name      = $_POST['name'];  
$email      = $_POST['email'];  
$sql        = "SELECT username,email FROM Users WHERE username = '" . $username . "' OR email = '" . $email . "'";  
$query      = mysql_query($sql);  
if (mysql_num_rows($query) > 0)  
{  
    echo "That username or email already exists";  
}  
else  
{  
    $insert = "INSERT INTO Users(username,password,name,email) VALUES ('" . $username . "','" . $password . "','" . $name . "','" . $email . "')";  
    $query  = mysql_query($insert);  
    if ($query)  
    {  
        echo "Thanks for registering. You may now login.";  
    }  
    else  
    {  
        echo "Insert failed";  
    }  
}  
?>

Also your script is full of SQL injection vulnerabilities, read php.net/manual/en/security.database.sql-injection.php :) — faffaffaff
– faffaffaff, Commented Jun 19, 2013 at 22:29
what I always do in this situation: after $insert put echo $insert. it will display your mysql query. copy/paste this query in phpmyadmin and see which error is. then post it here, so it will be easier to see where the problem is — chao
– chao, Commented Jun 19, 2013 at 22:29
Not directly related to solving your problem, but the use of mysql_* functions are really... well, not recommended. Have a look at mysqli_*, or better yet - PDO. :) — karllindmark
– karllindmark, Commented Jun 19, 2013 at 22:30

IchBin · Accepted Answer · 2013-06-19 22:39:40Z

1

Throw the error if the query fails so you can see what's happening. Take this out before you go live though.

$query = mysql_query($insert);
if (!$query) {
    die('Invalid query: ' . mysql_error());
} else {
    echo "Thanks for registering. You may now login.";
}

Also a couple of suggestions for your login form. Escape the stuff your inputting into your database using http://www.php.net/manual/en/function.mysql-real-escape-string.php. I'd also recommend finding a good regex to validate the email before you save it. And even hashing the password at a minimum.

answered Jun 19, 2013 at 22:39

IchBin

836 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

bugwheels94 Over a year ago

there are filters in php then why you want to reinvent the wheel

Klinetel Over a year ago

Is it possible to show a few examples of sanitizing the data with my current script above?

Zack Tanner Over a year ago

$username = mysql_real_escape_string($_POST['username']); I also recommend using mysqli...php.net/manual/en/book.mysqli.php

Klinetel Over a year ago

Would you know how to rewrite this in MySQLi? I'm not having much luck replicating this script.

Vilsol · Accepted Answer · 2013-06-19 22:37:45Z

1

Might be that you dont have a space in between Users and "(". Also, is your table with a capital letter. Maybe the table has some prefixes?

answered Jun 19, 2013 at 22:37

Vilsol

7321 gold badge8 silver badges17 bronze badges

1 Comment

Barmar Over a year ago

Spaces around delimiter characters are not necessary.

cssyphus · Accepted Answer · 2013-06-20 02:19:58Z

1

This is untested but it may be as simple as this:

$insert = "INSERT INTO Users(username,password,name,email) VALUES ('$username','$password','$name','$email')";

answered Jun 20, 2013 at 2:19

cssyphus

40.4k20 gold badges104 silver badges125 bronze badges

1 Comment

Klinetel Over a year ago

Thanks, would you know how to rewrite this script in Mysqli?

Collectives™ on Stack Overflow

PHP Simple Insert Issue

3 Answers 3

4 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related