else part doesn't work in php script

Question

In the following php script when correct un and pass were given, it displays Welcome.But when we give wrong pass as shown in the code, it doesn't output "Wrong username password combination".what is the reason for that?

<?php
$query = mysql_query($sql);
if (!$query)
{
    echo 'Invalid query: ' . mysql_error() . "\n";
    die($message);
}
if (mysql_fetch_assoc($query))
{
    $query = mysql_query($sql);
    $row   = mysql_fetch_assoc($query);
    if ($row['un'] == $un && $row['pd'] == $encpass)
    {
        echo "<h1>WellCome</h1>";
        echo '<br /><a href="home.php?' . SID . '">page 2</a>';
        echo $row['un'];
    }
    else
    {
        echo "Wrong user name password combination";
    }
}
?>

please indent your code. You can use tools like this if your code really does look like that. — AD7six
– AD7six, Commented Jun 26, 2013 at 10:01

luk2302 · Accepted Answer · 2013-06-26 10:00:08Z

2

$Since you check for the right password in the select there will not be any row to fetch if the password is wrong, therefore you will not enter the code after mysql_fetch_assoc.

Try

if($row = mysql_fetch_assoc($query)) {
  echo "<h1>WellCome</h1>";
  echo '<br /><a href="home.php?' . SID . '">page 2</a>';
  echo $row['un'];
} else {
  echo "Wrong user name password combination";
}

answered Jun 26, 2013 at 10:00

luk2302

57.5k24 gold badges108 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Peter Krauss · Accepted Answer · 2013-06-26 10:02:17Z

2

try

...
if(mysql_fetch_assoc($query)) {
$query = mysql_query($sql);
$row = mysql_fetch_assoc($query);
if($row['un'] == $un && $row['pd'] == $encpass) {
    echo "<h1>WellCome</h1>";
    echo '<br /><a href="home.php?' . SID . '">page 2</a>';
    echo $row['un'];
} else
    echo "Wrong user name password combination";
} else
echo "Wrong user name password combination";
...

answered Jun 26, 2013 at 10:02

Peter Krauss

14.1k30 gold badges187 silver badges343 bronze badges

Collectives™ on Stack Overflow

else part doesn't work in php script

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related