PHP Form to Database

Question

Hi I am trying to get a form to post to a database i can connect and the database and table are set up. but rather than post the contents of the fields in it posts the text firstname and secondname in to the columns.

below is my code:

mysql_select_db("company", $conn);

    $sqlCmd = sprintf("INSERT INTO names (firstname, secondname) VALUES ('%firstname','%secondname')", 
        mysql_real_escape_string($_POST["firstname"]),
        mysql_real_escape_string($_POST["secondname"]));

    //echo $sqlCmd;
    //die();    

    mysql_query($sqlCmd);

    mysql_close($conn);
}

?>



    <form method="post">
<input type="text" id="firstname" name="firstname"/>
<input type="text" id="secondname" name="secondname"/>
    <input name="submit" type="submit" value="Submit"/>
</form>

I need it to post the values from the fields. i am new to php and this is my first project, i would love some help.

just to add this is what i have managed after following a tutorial.

Thanks

Ryan

In the sptintf function replace %firstname and %secondanem with %s — Nedret Recep
– Nedret Recep, Commented Jul 12, 2013 at 14:45
changing it also did not work *it now does work it kept changing it when i published it. thanks — Ryan Thomas King
– Ryan Thomas King, Commented Jul 12, 2013 at 14:48

TheNiceGuy · Accepted Answer · 2013-12-20 23:39:24Z

1

Do not use php's mysql_ methods any more.

It is outdated: https://wiki.php.net/rfc/mysql_deprecation

Use mysqli_ or pdo instead

In your code you forgot the mysql_connect() anyways ;)

edited Dec 20, 2013 at 23:39

answered Jul 12, 2013 at 14:45

TheNiceGuy

3,7609 gold badges39 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nick Dickinson-Wilde · Accepted Answer · 2013-07-12 14:48:31Z

0

Just change your sprintf call to:

$sqlCmd = sprintf("INSERT INTO names (firstname, secondname) VALUES ('%s','%s')", 
    mysql_real_escape_string($_POST["firstname"]),
    mysql_real_escape_string($_POST["secondname"]));

Also consider using the newer mysqli function: http://www.php.net/manual/en/intro.mysqli.php

HTH; Pacific

answered Jul 12, 2013 at 14:48

Nick Dickinson-Wilde

1,0052 gold badges15 silver badges21 bronze badges

Collectives™ on Stack Overflow

PHP Form to Database

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related