Using MySQL Databases and PHP to Populate forms

Question

I am contemplating taking the next step with my PHP applications and making the option fields dynamic. That would open the doors for more automation.

I have drop downs throughout my project, they are used to select a specific user and I update them manually when a new user is added (which is also a manual process). But if i take the first step and make these drop downs become populated by a MySQL Database, then i can move on to dynamic user creation.

I know how I can achieve this, but I am curious about some other alternatives (If there is any).

Here is what I would do..

$query = ** MySQL Select * From Database Query **

echo '<select name="usernames">';

while($row == mysql_fetch_array($query))
{
     echo '<option>' . $row['username'] . '</option>';
}

echo '</select>';

So my questions is, would you do this differently? And why? Thanks!

Josh Curren · Accepted Answer · 2009-06-01 16:14:53Z

1

What you are doing will work fine. I like to make it into a function so that if I ever need that dropdown on another page I dont have to write a lot of code over again.

function userDD()
{
   $query = ** MySQL Select * From Database Query **
   $html = '<select name="usernames">';

   while($row == mysql_fetch_array($query))
   {
        $html .= '<option>' . $row['username'] . '</option>';
   }

   $html .= '</select>';

   return $html;
}

This code does exactly what your code does except it doenst use echo. Instead you use a variable ($html) to store all of the data then when you are done you return it.

edited Jun 1, 2009 at 16:14

answered May 31, 2009 at 15:01

Josh Curren

10.3k18 gold badges65 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Chris Bier Over a year ago

Can you show me an example of how this can be used in a function? I know how to make a function but I'm not sure how it can be applied here. It would help me a lot.

Josh Curren Over a year ago

I just added an example of your code in a function. You do everything the same except you store everything in a variable instead of echoing it. When everything is done you just return the html.

Etienne Perot · Accepted Answer · 2009-05-31 15:04:09Z

1

Your way is fine, but two things need to be changed:
- Run htmlentities() or htmlspecialchars() on all echoed HTML to avoid XSS. Unless you already sanitized it at database entry time but I find this practice silly.
- Add a value attribute to each <option> tag, otherwise you won't be able to retrieve the username selected. I suggest using the username's corresponding ID or something else that's unique to that user. If it's a string, use htmlentities/htmlspecialchars on it too.

edited May 31, 2009 at 15:04

answered May 31, 2009 at 14:52

Etienne Perot

4,8928 gold badges43 silver badges50 bronze badges

1 Comment

Mark Embling Over a year ago

This is not true. If there is no value="xyz on each <option>, it will return the text from the selected option. However, I do agree that providing an option (normally something like an ID) is the best way forward.

Galen · Accepted Answer · 2009-06-01 04:51:26Z

1

php file

$users = getUsers();

include('template.tpl');

template

<select name="username">
<?php foreach( $users as $user ): ?>
    <li><?= e( $user['username'] ) ?></li>
<?php endforeach; ?>
</select>

e is a function that escapes strings to prevent xss attacks

answered Jun 1, 2009 at 4:51

Galen

30.2k9 gold badges75 silver badges90 bronze badges

1 Comment

Pro777 Over a year ago

@chris Also, the alternative loop syntax shown here makes this code much easier to read. Inlining HTML code into your PHP statements is bad news bears.

KdgDev · Accepted Answer · 2009-05-31 14:57:58Z

0

I wouldn't put an SQL query in the same document as my output...

I'd create a document containing all SQL queries, in functions, and include that file. Just to keep things seperated.

answered May 31, 2009 at 14:57

KdgDev

14.6k48 gold badges128 silver badges159 bronze badges

Collectives™ on Stack Overflow

Using MySQL Databases and PHP to Populate forms

4 Answers 4

2 Comments

1 Comment

php file

template

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

php file

template

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related