How can I remove an attribute with jQuery?

Question

I can't seem to get removeAttr to work, I'm using the example I saw on the jQuery site. Basically onclick I add the attribute to disable a field (which works just fine) but when the user clicks again it should enable the field in question. I used alerts to make sure the else block is being fired, so I know that's not it.

Code:

$('#WindowOpen').click(function (event) {
  event.preventDefault();
  $('#forgot_pw').slideToggle(600);

  if('#forgot_pw') {
    $('#login_uname, #login_pass').attr('disabled','disabled');
  } else {
    $('#login_uname, #login_pass').removeAttr('disabled');
  }
});

Thanks.

if('#forgot_pw') will always run. I'm guessing this is a typo? — mtyaka
– mtyaka, Commented Nov 23, 2009 at 18:40
For future reference, jQuery recommends using the .prop() method (api.jquery.com/prop) when getting and setting input properties like disabled. It's more cross browser friendly depending on the version of jQuery you use and what browser your users navigate with. — jasonmerino
– jasonmerino, Commented Mar 9, 2012 at 17:36
possible duplicate of Remove disabled attribute using JQuery? — user2381114
– user2381114, Commented Apr 29, 2014 at 13:01

jball · Accepted Answer · 2010-11-18 17:02:42Z

38

All good used this:

$('#WindowOpen').toggle(
    function()
    {
        $('#login_uname, #login_pass').attr("disabled","disabled");     
    },
    function()
    {
        $('#login_uname, #login_pass').removeAttr("disabled");      
    });

edited Nov 18, 2010 at 17:02

jball

25.1k9 gold badges72 silver badges92 bronze badges

answered Nov 23, 2009 at 20:04

Tarek

8192 gold badges9 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Blake Taylor · Accepted Answer · 2009-11-23 18:45:30Z

7

Your problem is that the following line of code will always evaluate to true.

if('#forgot_pw')

try replacing with

if($('#forgot_pw').attr('disabled'))

answered Nov 23, 2009 at 18:45

Blake Taylor

9,3615 gold badges41 silver badges42 bronze badges

1 Comment

Tarek Over a year ago

Same problem, I get it to disable but not re-enable.

Dmitry Polushkin · Accepted Answer · 2010-08-08 19:47:33Z

4

$('#forgot_pw').attr('disabled', false);

should work for you.

answered Aug 8, 2010 at 19:47

Dmitry Polushkin

3,4332 gold badges42 silver badges47 bronze badges

Collectives™ on Stack Overflow

How can I remove an attribute with jQuery?

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related