String concatination in javascript

Question

<script type="text/javascript">
function Msg1(){
var a="noida";
id=1;
  document.getElementById('myText').innerHTML = '<p onclick="nice(id)">'+a+'</p>';
}
function Msg2(){
  document.getElementById('myText').innerHTML = 'Try message 1 again...';
}
</script>
<input type="button" onclick="Msg1()" value="Show Message 1" />
<input type="button"  onclick="Msg2()" value="Show Message 2" />
<p id="myText"></p>

when i click on Show Message 1 it send id as a charecter not 1 i want to it send me 1 Thanks

Halcyon · Accepted Answer · 2013-07-26 12:05:56Z

4

You could do something like:

'<p onclick="nice(\"' + id + '\")">'+a+'</p>';

Or:

'<p onclick="nice(' + escape(JSON.stringify(id)) + ')">'+a+'</p>';

But this gets very unreadable very quickly.

Using this method you can't send things that aren't easily serializable. A more robust, and involved, solution would use the DOM API and EventListener API.

Example:

var id = { foo: "bar" };
var p = document.createElement("p");
p.addEventListener("click", function () {
    nice(id);
});
p.innerText = "ipsum lorem";
document.body.appendChild(p);

answered Jul 26, 2013 at 12:05

Halcyon

57.7k10 gold badges93 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ravendra Kumar Over a year ago

please do some favor if i want send id in double quote. then its not works

MDEV · Accepted Answer · 2013-07-26 12:05:43Z

0

You already have concatenation right near where you need it:

'<p onclick="nice('+id+')">'+a+'</p>';

answered Jul 26, 2013 at 12:05

MDEV

10.9k2 gold badges35 silver badges50 bronze badges

Comments

Naveen Kumar Alone · Accepted Answer · 2013-07-26 12:18:44Z

0

make your innerHTML as

'<p onclick="nice(\"' + id + '\")">'+a+'</p>'

Replace your Msg1() Javascript function as below

function Msg1(){
   var a="noida";
   var id = 1;
   document.getElementById('myText').innerHTML = '<p onclick="nice(\"' + id + '\")">'+a+'</p>';
}

edited Jul 26, 2013 at 12:18

answered Jul 26, 2013 at 12:06

Naveen Kumar Alone

7,6985 gold badges40 silver badges59 bronze badges

Collectives™ on Stack Overflow

String concatination in javascript

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related