Javascript - concat string does not work as expected

Question

What's the wrong with this Javascript line?

user: h.reem
domain: somedomain

var target = "//account/win/winlogin.aspx" + 
             "?username=" + 
             user.toString() + 
             "&domain=" + 
             domain.toString();

the resutl is always:

//account/win/winlogin.aspx?username=h.reem

Any idea!!

enter image description here

Not for me: jsfiddle.net/92R99/1 . What are user and domain? properties of an object? Are they strings? Show us the definition of those. — Matt
– Matt, Commented Aug 8, 2011 at 13:13
why don't you try using domain and user instead of domain.toString and user.toString ? As I feel that domain and user are strings! — linuxeasy
– linuxeasy, Commented Aug 8, 2011 at 13:14
your jsfiddle alerts '//account/win/winlogin.aspx?username=h.reem&domain=somedomain' here — BiAiB
– BiAiB, Commented Aug 8, 2011 at 13:15
@Matt: These values (user) & (domain) are coming from ActiveX. When I wrote them as you wrote (hard codded) then it worked well, but in my case it does not work! — French Boy
– French Boy, Commented Aug 8, 2011 at 13:16
@French: You might want to update your question and say that ;)... It's quite crucial! I've never used ActiveX, so can't help you any further I'm sorry... but someone else will be able to! — Matt
– Matt, Commented Aug 8, 2011 at 13:18

Alex K. · Accepted Answer · 2011-08-08 13:32:55Z

2

alert(user + "X") shows only h.reem

The ActiveX component is probably returning a null terminated string (I've seen this with Scripting.TypeLib & a couple of the AD objects for example) so concatenating it with another string fails. (You can verify this if 0 === user.charCodeAt(user.length - 1)).

You will need remove the last character before using the string;

user = user.substr(0, user.length - 1);

answered Aug 8, 2011 at 13:32

Alex K.

177k32 gold badges276 silver badges299 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Brian · Accepted Answer · 2011-08-08 13:16:18Z

0

try:

var sUser = user.toString();
var sDomain = domain.toString();

var target = "//account/win/winlogin.aspx" + "?username=" + sUser + "&domain=" + sDomain;

The above might not fix your problem but it should expose it - Could be that your user.toString() method isn't returning a string and is short-circuiting things... If this doesn't answer your question I'd be glad to assist further, but it would be helpful if you posted the implementation or source of "user" somewhere ...

answered Aug 8, 2011 at 13:16

Brian

2,78116 silver badges12 bronze badges

1 Comment

French Boy Over a year ago

Thanks for your answer. It doesn't work. I added a screen-shot from my code. Kindly see it.

Collectives™ on Stack Overflow

Javascript - concat string does not work as expected

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related