javascript change onclick attribute

Question

I have a script that enables my uses to block / unblock users. They're both in the same function 'blockToggle(type, user, button)' and depending on the type( either block or unblock) it executes that script. But what I'm trying to do is if the current user doesnt have another user blocked, they can block them with the button, but when the user clicks the button, they have to refresh the page to unblock the user. I want the onclick attribute to change right away once the user clicks it without refreshing the page. Here are a few things i've tried:.

document.getElementById("blockBtn").onclick = "blockToggle('unblock', 'user', 'blockBtn')";

document.getElementById("blockBtn").setAttribute( "onClick", "javascript: blockToggle('unblock', 'user', 'blockBtn')";

document.getElementById("blockBtn").onclick = function(){ "blockToggle('unblock', 'user', 'blockBtn')"};

Neither one of these solutions worked for me. And I couldn't seem to find a solution from google search either. Is there anything I'm overseeing here? I'm sure the answers right in front of me.

You have a syntax error in your code. Look how the code is highlighted. — MMM
– MMM, Commented Sep 14, 2013 at 18:37
Are unblock, user, and blockBtn supposed to be literal strings or variable names? If they're variables, you shouldn't put them in quotes. — Barmar
– Barmar, Commented Sep 14, 2013 at 18:43
the only one thats a variable is user, which in my actual code i don't have them it quotes — Vince
– Vince, Commented Sep 14, 2013 at 18:54
I actually think it was a syntax error in my code :O i just deleted it all and wrote it again and using the .setAttribute function in javascript worked. — Vince
– Vince, Commented Sep 14, 2013 at 19:07

Sergio · Accepted Answer · 2013-09-14 18:30:09Z

1

I dont know how your function blockToggle() looks like, but try this, without the extra quotes:

document.getElementById("blockBtn").onclick = function(){ 
    blockToggle(unblock, user, blockBtn);
};

I am assuming your function blockToggle is declared and that unblock user & blockBtn are declared variables also.

answered Sep 14, 2013 at 18:30

Sergio

28.9k11 gold badges90 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ruan Mendes Over a year ago

I think unblock, user and blockBtn are strings

Ruan Mendes · Accepted Answer · 2013-09-14 18:53:46Z

0

Stay away from setting handlers as strings. Just use a normal anonymous function that calls your blockToggle.

document.getElementById("blockBtn").onclick = function(){ 
    blockToggle('unblock', 'user', 'blockBtn');
};

answered Sep 14, 2013 at 18:53

Ruan Mendes

92.7k31 gold badges161 silver badges225 bronze badges

Collectives™ on Stack Overflow

javascript change onclick attribute

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related