set onclick attribute in Javascript

Question

When I run this Javascript code

var anchor = document.createElement("a");
anchor.style = "cursor:pointer;color:blue;";
 anchor.onclick = "this.parentNode.parentNode.removeChild(this.parentNode);";
 anchor.innerHTML = "remove";
 div.appendChild(anchor);

My anchor is created as <a style="cursor: pointer; color: blue;">remove</a> The onclick attribute is missing and the onclick function does not work.

Can I fix it?

Note that setting an element property doesn't necessarily affect the related attribute and vice versa. — RobG
– RobG, Commented Jan 6, 2015 at 2:30

epascarello · Accepted Answer · 2015-01-06 02:04:20Z

2

You are setting it to a string and it does not actually set the attribute. Use a closure.

anchor.onclick = function() { this.parentNode.parentNode.removeChild(this.parentNode); };

ideally you would be using addEventListener

anchor.addEventListener("click", function(){ this.parentNode.parentNode.removeChild(this.parentNode); }, false);

answered Jan 6, 2015 at 2:04

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

xralf Over a year ago

Thank you. Only the solution with addEventListener works. But it's good to see what does not work as well.

Collectives™ on Stack Overflow

set onclick attribute in Javascript

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related