Using PHP Functions to get database values

Question

So i have here a function that i created. It worked when i used a postgres database but once i switched over to mysqli, for some reason, it doesn't return the id. Here is my function:

function getAccID($connection, $username){
    $res = mysqli_query($connection, "SELECT accounts_id FROM people WHERE people.username ='$username'");
    if ($res){
        $row = mysqli_fetch_assoc($res);
        if ($row){
            return ($row[0]);
        }
    }else{
        //handle the error
    }

}

And here is how i declare the function:

$accountID = getAccID($connection, $user);
$p->addContent("Account ID: $accountID");
if (!$accountID) $p->addContent('Error: ' . mysqli_error($connection) . "<br>");

PS: If anyone says anything about me using mysqli_query instead of prepare statements, i will murder some babies :L. I'm using it to test, and once everything works, it's easy to switch to prepared statements.

FIXED

Problem with this was with Postgres i could use the id of the fields, but with mysqli, i have to use the name.

Therefore this will not work

$row[0];

It'll have to be:

$row["name_of_field"];

(If you are going to "test" something, why not test the actual something that will be used?) — user2246674
– user2246674, Commented Oct 3, 2013 at 23:25
because i like to test as i go along. It's just the way i work. — Anuj Hari
– Anuj Hari, Commented Oct 3, 2013 at 23:26
and it's easier to test with queries than it is with prepared statements. — Anuj Hari
– Anuj Hari, Commented Oct 3, 2013 at 23:27
(If you're going to switch to something else, you're not testing it; this is an inappropriate mock scenario.) — user2246674
– user2246674, Commented Oct 3, 2013 at 23:27
Anyway, 1) do something in "handle the error" and; 2) verfify the result of mysqli_fetch_assoc is what you think it is - i.e. that there are results and that you're returning the desired value within said row (I see a suspicious-looking if, not a traditional while, and no $row["accounts_id"]). As it is now, either-or could be "failing" which would result in an unexpected result - mainly, no useful return value - due to incomplete execution flow pathing. — user2246674
– user2246674, Commented Oct 3, 2013 at 23:34

zod · Accepted Answer · 2013-10-03 23:40:40Z

1

As you are using mysqli_fetch_assoc

the $row should have the name of the field

use $row['id'] instead of $row[0]

answered Oct 3, 2013 at 23:40

zod

12.5k25 gold badges74 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Anuj Hari Over a year ago

I literally just figured this out and was about to post the response. Haha thanks anyway.

Anuj Hari Over a year ago

To anyone else having this problem, this is the correct answer.

Collectives™ on Stack Overflow

Using PHP Functions to get database values

FIXED

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

FIXED

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related