Getting array from PHP function

Question

My db table looks like that

enter image description here

I'm trying to get page title and content from this function

function page($current, $lang){
    global $db;
    $txt='txt_'.$lang;
    $title='title_'.$lang;
    $data=$db->query("SELECT '$txt', '$title' FROM pages WHERE `id`='$current'");
    $data=$data->fetch_array(MYSQLI_BOTH);
    return $data;
}

Then at the beginning of the index page getting array values

$data=page($id, $lang);

And using like this example

<title><?=$data[1]?></title>

But getting every time the same result title_en (en is my language variable.). What's wrong with my code?

Jason McCreary · Accepted Answer · 2011-09-19 18:03:44Z

6

Don't single quote your fields. MySQL interprets this as a string.

$data=$db->query("SELECT $txt, $title FROM pages WHERE `id` = $current");

Alternatively you can use backticks in MySQL. But note that $current still shouldn't have them assuming it's an integer field.

$data=$db->query("SELECT `$txt`, `$title` FROM pages WHERE `id` = $current");

answered Sep 19, 2011 at 18:03

Jason McCreary

73.3k23 gold badges139 silver badges177 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Robert Martin Over a year ago

To clarify, when you single quote your fields, you are essentially asking the database for constant strings. It's like saying "give me a copy of the string $title for every row in the database"

Jason McCreary Over a year ago

@Robert Martin, nice additional clarification, I have added it to my answer.

Tural Ali Over a year ago

$data=$db->query("SELECT n.name, p.$txt, p.$title FROM pages AS p, nav AS n WHERE id=$current"); WHAT'S WRONG IN THIS CODE?

Jason McCreary Over a year ago

One thing at a time friend. You should post another question if you are progressing further down the rabbit hole (as it seems from your new query).

Collectives™ on Stack Overflow

Getting array from PHP function

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related