unexpected not defined error in javascript

Question

I have page in which there's a function which calls a function from js file.

the code which calls function in js file:

<script language="javascript" type="text/javascript">
var qc = qc_chat;
window.onload = function()
{
qc.setup('<?php echo $p; ?>');
}
</script>

I am including qc.js file using this code:

function doThat() {
    $.ajax({
        url:    'http://www.example.com',
        type: 'GET',
        data: 'adrs='+getHost( document.domain ),
        dataType:   'jsonp',
        jsonp:  false,
        jsonpCallback: 'methodCallback',
        success: function( data ) {
            if( data.message == "yes" ) {

            } else {

        $.getScript("qc.js"); //files m including using this ajax
    $.getScript("tools.js");  //files m including using this ajax
            }
        }, 
        error: function( error ) {
            console.log( error ); 
        }
    });
}

and i am calling doThat() using <body onload="doThat();">

but i am getting the error in console Uncaught ReferenceError: qc_chat is not defined

Thanks

Where is qc_chat defined. if it is not defined at all you will get this error. — PSL
– PSL, Commented Oct 9, 2013 at 18:05
Yes, please show where it is defined. It is not in your code. — Diodeus - James MacFarlane
– Diodeus - James MacFarlane, Commented Oct 9, 2013 at 18:06
The onLoad events are going to fire before any of the async calls finish... — Izkata
– Izkata, Commented Oct 9, 2013 at 18:06

Barmar · Accepted Answer · 2013-10-09 18:09:05Z

3

Since $.getScript is asynchronous, anything that depends on the script it loads must be done in its callback function. So it should be:

$.getScript('qc.js', function() {
    qc_chat.setup('<?php echo $p; ?>');
});

answered Oct 9, 2013 at 18:09

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

zzlalani Over a year ago

may be <body onload="doThat('<?php echo $p; ?>');"> and function doThat(_p) { and qc_chat.setup(_p) since the other code is a .js file

user2855825 Over a year ago

error is not shwoing but my code is also not working...which is dependent on that files. :(

Barmar Over a year ago

If it's not getting an error, then it's running the function. I can't explain why it's not doing what you expect. Use the JS debugger, set a breakpoint on the qc_chat.setup line and see what's happening.

user2855825 Over a year ago

@Barmar nohting happend...i think i need to load the doThat() before the page loads so that it load qc.js before the page loads completey? how to do that ?

Barmar Over a year ago

That seems unlikely. But you can but the call do doThat() in a <script> tag in the <head> instead of the onload attribute, and it will run before the body loads. But since it uses AJAX, qc.js will still not be loaded until later.

|

vp_arth · Accepted Answer · 2013-10-09 18:19:18Z

0

When I can't to edit the place where some modules connects, I use this snippet:

var waitForqcchat = setInterval(function(){
  if(typeof qcchat != 'undefined'){
    clearInterval(waitForqcchat);
    //here I sure, that module connected
    qcchat.setup('<?=$p?>');
  }
}, 200);

You should also write a logic to limit waiting if qcchat can never to be connected

answered Oct 9, 2013 at 18:19

vp_arth

15k4 gold badges43 silver badges72 bronze badges

2 Comments

Barmar Over a year ago

It works, but it's an incredible kludge. Learn to use callback functions properly.

vp_arth Over a year ago

Agree, this only for cases, when I can't modify/detect the place where script connected. Place like $.getScript('qc.js')

Collectives™ on Stack Overflow

unexpected not defined error in javascript

2 Answers 2

11 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

11 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related