Regex Replace issue

Question

I tried to use regex replace method to replace xxx="yyy" pattern of text in given string like.

My pattern is : /^[a-zA-Z0-9.;:|_-]+="[a-zA-Z0-9.;:_-]+\"/

Code:

var userinput = '<div id="c16430" style="color:red;" class="css-btn">';         
var pattern = /^[a-zA-Z0-9.;:|_-]+="[a-zA-Z0-9.;:_-]+\"/;
userinput = userinput.replace( pattern, "Replaced..." );

But it is not working... jsfiddle. What is wrong?

Thanks in advance..

The operator ^ is used to say that you're search at the beggining of the subject, in your case, it have not to be used because you're search any place of the string. — DontVoteMeDown
– DontVoteMeDown, Commented Oct 10, 2013 at 13:34
Anyway, everytime you need to deal with regex with JavaScript test it on RegexPal — DontVoteMeDown
– DontVoteMeDown, Commented Oct 10, 2013 at 13:37
I would recommend you re-tag this "javascript" instead of "jquery" — musefan
– musefan, Commented Oct 10, 2013 at 13:39

musefan · Accepted Answer · 2013-10-10 13:33:11Z

5

You have a couple of problems:

You are trying to match the start of the input, using ^ at the start
You are not using the global flag /g at end, so it would only replace the first match.

This will work:

var pattern = /[a-zA-Z0-9.;:|_-]+="[a-zA-Z0-9.;:_-]+\"/g;

Here is your updated example

answered Oct 10, 2013 at 13:33

musefan

48.5k21 gold badges144 silver badges193 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

DontVoteMeDown Over a year ago

Didn't like Muse but you deserve +1 haha

musefan Over a year ago

@DontVoteMeDown: Ha! I only usually get "btw, Muse are awesome!", but thanks for seeing past your hatred ;-)

DontVoteMeDown Over a year ago

@musefan haha i'm just kidding.

hwnd · Accepted Answer · 2013-10-10 13:53:26Z

2

Simplified for you. As stated this could match false input, not knowing how strict your input is.

var pattern = /[^ =]+="[^"]+"/g;

or ignore non-word characters

var pattern = /[^\W]+="[^"]+"/g;

or stick with the original idea, the i modifier is used to perform case-insensitive matching.

var pattern = /[a-z0-9_.|:;-]+="[^"]+"/ig;

edited Oct 10, 2013 at 13:53

answered Oct 10, 2013 at 13:36

hwnd

70.9k4 gold badges100 silver badges135 bronze badges

1 Comment

musefan Over a year ago

Actually, your regex will match false positives. Consider this input: <div id="c16430" style="color:red;" class="css-btn">="a"</div>. Of course, we don't know how strict the input html is in the OP's case, so it may work perfectly well for them... this is why I avoided trying to improve the regex, and just pointed out the problems with the OP's example

Paul Roub · Accepted Answer · 2016-05-16 13:48:40Z

0

It is perfect

/\s[^=]+\=\".*?\"/g

edited May 16, 2016 at 13:48

Paul Roub

36.5k27 gold badges88 silver badges95 bronze badges

answered May 16, 2016 at 13:42

shivamrajput

12 bronze badges

Collectives™ on Stack Overflow

Regex Replace issue

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related