Echo JSON through a loop in PHP?

Question

I have a loop that grabs DB values and creates an object. I want to echo a JSON object every time the loop is iterated through. As of now, I just get blank in my console. Also, those commented out printf statements work fine. Any help would be much appreciated!

AJAX call

$.ajax({
        url:'ajax/ipGet.php',
        type: 'GET',
        dataType:'json',
        success:function(response){
            console.log(response);
        }

    });

PHP Data Generation

$infoArray = new Array();
while($row = mysqli_fetch_array($getIpQuery, MYSQLI_NUM)){
    for($x=0;$x<count($row);$x++)
    {
        $getIpInfo = mysqli_query($dbcon,"SELECT * FROM ipInfo WHERE address='$row[$x]'");
        $retrievedInfo = mysqli_fetch_array($getIpInfo,MYSQLI_NUM);
        $ipInfo->ipAddress = $retrievedInfo[0];
        $ipInfo->port = $retrievedInfo[1];
        $ipInfo->status = getStatus($ipInfo->ipAddress, $ipInfo->port);
        array_push($infoArray,$ipInfo);

    } 
  }

echo json_encode($infoArray);

Thanks for any help!

~Carpetfizz

I don't see why this question is downvoted. The question is clear to understand, according code is added and everything is well formatted. It would be great if downvoters could comment their decisions. I give you +1 to compensate. — dialogik
– dialogik, Commented Oct 20, 2013 at 20:48
Thanks! Yeah, like you said it would be helpful if they said what I did wrong. — Carpetfizz
– Carpetfizz, Commented Oct 20, 2013 at 20:50

zerkms · Accepted Answer · 2013-10-20 20:27:59Z

2

json must be a single self-contained entity. You're outputting MULTIPLE separate bits of JSON text, which is incorrect.

JSON encoding should be the very LAST thing you do, e.g.

while(...) {
   $array[] = ....
}
echo json_encode($array);

Consider what you're doing from the client perspective... building an array of ipinfo, so you run the loop once and produce

{"ipAddress":"127.0.0.1","port":80,....}

But you're doing it multple times, so you end up with

{"ipAddress":"127.0.0.1","port":80,....}{"ipAddress":"127.0.0.1","port":80,....{"ipAddress":"127.0.0.1","port":80,....}

as your output, and now you've got illegal javascript. Remember that JSON text is essentialy the right-hand-side of a Javascript assignment operation, e.g.

var somevar = ...json_goes_here...;

So you're doing

var stuff = {...}{...}{...};

which is an outright syntax error, instead of

var stuff = [{...},{...},{...}];

which would be correct.

edited Oct 20, 2013 at 20:27

zerkms

256k73 gold badges447 silver badges551 bronze badges

answered Oct 20, 2013 at 20:26

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Carpetfizz Over a year ago

Thanks! So, when I get the array in Javascript, I can access each object with var object = stuff[x] ?

Marc B Over a year ago

yes. json's just a transport/encoding format. you should NEVER have to deal with the raw json string itself. you decode the string into a native structure, deal with that structure, then re-encoding into json for shipment.

Carpetfizz Over a year ago

Cool, so I updated to the code in the original post-but I'm still getting the same issue.

Marc B Over a year ago

your db stuff is also another problem. you're running nested queries, which sould be rewritten as a single joined query. and you seem to be treating mysql_fetch calls as returning the ENTIRE result set. they only return a single row of the result.

Carpetfizz Over a year ago

Right, so what happens is that each user has a list of IPs. There's another table that stores information for the IPs. So, for all the IPs under the user, I want to be able to build a JSON object, then send it out to the client side. The second query is to get all the information for the IP in question.

|

Collectives™ on Stack Overflow

Echo JSON through a loop in PHP?

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related