syntax error for my php and javascript

Question

here is my php code

echo ("<td><img src='edit.jpg' width='20' alt='Edit' title='EDIT DATA' onClick=\"swipe2('" + . mysql_result($result, $i, 'no'). + '');'style='cursor:pointer;'" ></td>");

my function

function swipe2(no) { window.open ( 'edit.php?no='+no,'newwindow') }

the problem are syntax and also when i click the link the new window by (function) wont open thanks in advance..

Dipesh Parmar · Accepted Answer · 2013-10-31 07:42:33Z

0

Replace

onClick=\"swipe2('" + . mysql_result($result, $i, 'no'). + '');

with

onClick=\"swipe2('" . mysql_result($result, $i, 'no'). "');
                      ---------------------------------^--

also replace

style='cursor: pointer;'" ></td>");

with

style='cursor: pointer;'></td>");
----------------------^^^-----

you have extra " in above code

So your complete code would be.

echo ("<td>
    <img src='edit.jpg' width='20' alt='Edit' title='EDIT DATA' 
        onClick=\"swipe2('". mysql_result($result, $i, 'no') ."');
       style='cursor:pointer;'>
</td>");

answered Oct 31, 2013 at 7:42

Dipesh Parmar

27.3k8 gold badges65 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

RAN RAN Over a year ago

it has no error now, but now it has no cursor pointer and still no newwindow open

innocuo · Accepted Answer · 2013-10-31 20:16:58Z

this worked for me:

<?php
//replace 0 with your mysql_result call
$result = 0;
echo ("<td><img src=\"edit.jpg\" width=\"20\" alt=\"Edit\" title=\"EDIT DATA\" onClick=\"swipe2(".$result.");\" style=\"cursor:pointer;\" ></td>");
?>
<script>
    function swipe2(no) { window.open ( 'edit.php?no='+no,'newwindow') }
</script>

some tips:

use double quotes for attributes (not required, but more "standard"). So you have to escape them using \"
try not to put mix function calls with string concatenation. Put the call in a variable, and use the variable in the string. It's easier to read and maintain.
I removed the quotes in the swipe2(something) called, assuming your result is always a number. If it isn't then you'll have to add quotes ( single might work here better, or escaped double quotes, in which case you might need to escape them and escape the backslash too: \\"

Collectives™ on Stack Overflow

syntax error for my php and javascript

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related