-1

This is a heart with a wishlist, I want to add the product to my wishlist.

I have a syntax error in the console

Uncaught SyntaxError: expected expression, got '}'

Dreamweaver shows me no errors

<div>
  <i id="id'. $result->id .'" 
     class="far fa-heart cart_heart" 
     onClick="add_to_wishlist("' . $result->id . '", "add")">
  </i>
</div>  

<script>
   function add_to_wishlist(id) {
      alert(id);
   }    
</script>

HTML output

<i id="id17254" 
   class="far fa-heart cart_heart" 
   onclick="add_to_wishlist(" 17254",="" "add")"="">
</i>

php output with html (need to ajax)

    if(empty(h($result->id)))
    {  }
    else 
    {
        $html .= '
            <td width="30%"><label>Heart:</label></td>  
            <td width="70%">
            
            <div>
            <i id="id'. $result->id .'" class="far fa-heart cart_heart"
            onClick="add_to_wishlist(' . $result->id . ', 'add')"></i>
            </div>  
            
            </td>  
        </tr>
        ';  
        }

    $html .= '</table></div>';

echo $html;
Improve this question
12
  • Check the resulting markup (or just have a look at the strange syntax highlighting) and you should see the problem Commented Jan 13, 2021 at 12:20
  • 1
    You are using double quotes(") and single quotes (') at the wrong places. correct way is onClick="add_to_wishlist('" . $result->id . "', 'add')" Commented Jan 13, 2021 at 12:30
  • @Not A Bot I tried this php syntax error Parse error: syntax error, unexpected Commented Jan 13, 2021 at 12:34
  • @Not A Bot this is js inside php code:) Commented Jan 13, 2021 at 12:35
  • @sagittarius Inside PHP code means inside echo statement? Commented Jan 13, 2021 at 12:45

1 Answer 1

Reset to default
0

Not having clarity over the code, it is somewhat difficult to tell the main cause of the error, as according to the error you are getting is

Uncaught SyntaxError: expected expression, got '}'

There is a code of block that is ending with these curly braces }

Also, you need to escape characters to make your code work properly.

$r = 1; //I am assuming this for simplicity

$html ='
     <div>
        <i id="id'.  $r  .'" class="far fa-heart cart_heart"
           onClick="add_to_wishlist(\'' .  $r  . '\', \'add\')"></i>
      </div> ';  

echo $html;

The above code produces this HTML code

<div>
   <i id="id1" 
      class="far fa-heart cart_heart" 
      onclick="add_to_wishlist('1', 'add')">
   </i>
</div>

You need to escape characters(\') to work around single quotes(') that is in your PHP code.

 onClick="add_to_wishlist(\'' .  $r  . '\', \'add\')"

Here adding \' helps in formatting parameters correctly.

Improve this answer
Sign up to request clarification or add additional context in comments.

Comments