Javascript write variable to div

Question

I'm trying to write the variable "current" to the div "bank" using the following code when the user clicks on the image: document.getElementById('bank').innerHTML = current

According to my research, this should work, but it doesn't. Here's my code:

<!DOCTYPE html>
<html>
    <head>
        <title></title>
        <link rel="stylesheet" type="text/css" href="css/default.css">
        <script>
            var current = 0;
            var totalThisGame = 0;

            function onButtonClick
            {
                current = current +1;
                totalThisGame = totalThisGame +1;
                document.getElementById('bank').innerHTML = current;
            }
        </script>
    </head>
    <body>
        <div id="left">
            <div id="bank">
            </div>
            <img id="image" src="img/image.png" alt="image" onclick=onButtonClick();>
        </div>
        <div id="middle">
        </div>
        <div id="right">
        </div>
    </body>
</html>

MAQU · Accepted Answer · 2013-10-31 10:14:52Z

4

you miss the () behind your function

function onButtonClick()
            {
                current = current +1;
                totalThisGame = totalThisGame +1;
                document.getElementById('bank').innerHTML = current;
            }

your code is working fine for me

answered Oct 31, 2013 at 10:14

MAQU

5622 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Micha Sprengers Over a year ago

Thanks! I forgot to use them... how stupid.. :p It works fine now ;)

Silviu Burcea Over a year ago

@MichaSprengers you should also accept this answer. This is how StackOverflow works.

Micha Sprengers Over a year ago

I know and I will, I just had to wait for 10 minutes for some reason... So in a minute this will be accepted ;) Thanks for pointing it out tho

user2663434 · Accepted Answer · 2013-10-31 10:14:30Z

1

error

change  function onButtonClick ->  function onButtonClick()

<img id="image" src="img/image.png" alt="image" onclick=onButtonClick();> to

<img id="image" src="img/image.png" alt="image" onclick="onButtonClick();">

answered Oct 31, 2013 at 10:14

user2663434

1 Comment

Micha Sprengers Over a year ago

Thanks that helped! But it doesn't matter if I use quotes around the onclick tho.. it works both ways..

DavidB · Accepted Answer · 2013-10-31 10:13:51Z

0

Try:

<img id="image" src="img/image.png" alt="image" onclick="onButtonClick();">

answered Oct 31, 2013 at 10:13

DavidB

2,5973 gold badges35 silver badges66 bronze badges

1 Comment

EricG Over a year ago

If you could write that you wrote quotations, that would make us understand your proposal better :)

TN888 · Accepted Answer · 2013-10-31 10:15:11Z

0

Your function is badly defined. It should be function onButtonClick() instead of function onButtonClick. Then use that HTML code : <img id="image" src="img/image.png" alt="image" onclick="onButtonClick();">

answered Oct 31, 2013 at 10:15

TN888

7,7499 gold badges52 silver badges85 bronze badges

Comments

BhushanK · Accepted Answer · 2013-10-31 10:15:18Z

0

you forgot the function parenthesis

       function onButtonClick()
        {
            current = current +1;
            totalThisGame = totalThisGame +1;
            document.getElementById('bank').innerHTML = current;
        }

answered Oct 31, 2013 at 10:15

BhushanK

1,2396 gold badges24 silver badges39 bronze badges

Comments

Govan · Accepted Answer · 2013-10-31 10:15:18Z

0

Bank has to be in double quotes: document.getElementById("bank").innerHTML = current;

answered Oct 31, 2013 at 10:15

Govan

7,7816 gold badges29 silver badges42 bronze badges

Comments

Lalbhusan Yadav · Accepted Answer · 2013-10-31 10:16:44Z

0

Always use any of the functions on any event in html within double quotes.Try this

answered Oct 31, 2013 at 10:16

Lalbhusan Yadav

1119 bronze badges

Comments

EricG · Accepted Answer · 2013-10-31 10:18:13Z

0

You should read the console message and you'd notice that your function is odd. Note parenthesis.

function onButtonClick
{

becomes

function onButtonClick()
{

answered Oct 31, 2013 at 10:18

EricG

3,8491 gold badge25 silver badges35 bronze badges

Comments

Shreedhar · Accepted Answer · 2013-10-31 10:20:45Z

0

change

function onButtonClick to  function onButtonClick()

<img id="image" src="img/image.png" alt="image" onclick=onButtonClick();>

to

<img id="image" src="img/image.png" alt="image" onclick="onButtonClick();">

it would be better if you put your javascript before the body closing tag or use window.onload method

answered Oct 31, 2013 at 10:20

Shreedhar

5,6903 gold badges24 silver badges27 bronze badges

Collectives™ on Stack Overflow

Javascript write variable to div

9 Answers 9

3 Comments

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

9 Answers 9

3 Comments

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related