Writing to a div from javascript

Question

I'm trying to make a div box where it displays a randomized quote generated in the javascript, but it does not display when I run the code.

My html is simply

<div id="quotebox"></div>

my javascript is

var quotes = new Array()
quotes[0]="Simplicity is the ultimate sopistication";
quotes[1]="While I thought that I was learning how to live, I have been learning how to die.";
quotes[2]="The greatest deception men suffer is from their own opinions.";
quotes[3]="Art is never finished, only abandoned";
quotes[4]="Iron rusts from disuse; water loses its purity from stagnation. Even so does inaction sap the vigor of the mind.";

var randQuote=Math.floor(Math.random()*(quotes.length));
function showQuote(){
    document.getElementById("quotebox").innerHTML = quotes[randQuote];
}

Am I just making a silly mistake or what is going on? I've tried several different things now and it still doesn't display to the div.

Are you calling showQuote() anywhere? Or try checking your quotes variable to make sure it has the data in it. — Zack Argyle
– Zack Argyle, Commented Mar 12, 2014 at 4:05
I've tried calling it both in the <body> and <div> but nothing happens. What do you mean check the quotes variable? — user3113376
– user3113376, Commented Mar 12, 2014 at 4:14

Raghu · Accepted Answer · 2014-03-12 04:15:07Z

1

You are not calling showQuote(); Here is the working JS fiddle http://jsfiddle.net/9bmAN/

var quotes = new Array()
quotes[0]="Simplicity is the ultimate sopistication";
quotes[1]="While I thought that I was learning how to live, I have been learning how to die.";
quotes[2]="The greatest deception men suffer is from their own opinions.";
quotes[3]="Art is never finished, only abandoned";
quotes[4]="Iron rusts from disuse; water loses its purity from stagnation. Even so does inaction sap the vigor of the mind.";

var randQuote=Math.floor(Math.random()*(quotes.length));
function showQuote(){
    document.getElementById("quotebox").innerHTML = quotes[randQuote];
}

showQuote()

edited Mar 12, 2014 at 4:15

answered Mar 12, 2014 at 4:12

Raghu

2,5711 gold badge19 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

sabithpocker Over a year ago

what is this comment for?

Raghu Over a year ago

i deleted it..got mistakenly posted here. Thanks for notifying

deviloper · Accepted Answer · 2014-03-12 04:15:28Z

0

Make sure you have an element (div, td, whatever) with the id: "quotebox":

function showQuote(){
   var quotes = new Array()
quotes[0]="Simplicity is the ultimate sopistication";
quotes[1]="While I thought that I was learning how to live, I have been learning how to die.";
quotes[2]="The greatest deception men suffer is from their own opinions.";
quotes[3]="Art is never finished, only abandoned";
quotes[4]="Iron rusts from disuse; water loses its purity from stagnation. Even so does inaction sap the vigor of the mind.";

var randQuote=Math.floor(Math.random()*(quotes.length));
    document.getElementById("quotebox").innerHTML = quotes[randQuote];
}
</script>
<body onload="showQuote();">
<div id="quotebox">

</div>
</body>

edited Mar 12, 2014 at 4:15

answered Mar 12, 2014 at 4:07

deviloper

7,25210 gold badges52 silver badges79 bronze badges

Comments

Amila Iddamalgoda · Accepted Answer · 2014-03-12 04:16:34Z

0

<script>
window.onload=function(){   
    var quotes = new Array()
    quotes[0]="Simplicity is the ultimate sopistication";
    quotes[1]="While I thought that I was learning how to live, I have been learning how to die.";
    quotes[2]="The greatest deception men suffer is from their own opinions.";
    quotes[3]="Art is never finished, only abandoned";
    quotes[4]="Iron rusts from disuse; water loses its purity from stagnation. Even so does inaction sap the vigor of the mind.";

    var randQuote=Math.floor(Math.random()*(quotes.length));
        document.getElementById("quotebox").innerHTML = quotes[randQuote];

};     
  </script>

<body >
<div id="quotebox"></div>
</body>

edited Mar 12, 2014 at 4:16

answered Mar 12, 2014 at 4:09

Amila Iddamalgoda

4,31612 gold badges52 silver badges86 bronze badges

2 Comments

user3113376 Over a year ago

Nothing is still being displayed in the div.

Amila Iddamalgoda Over a year ago

Above code works fine :) Check the update! use window.onload()

Chandra Prakash · Accepted Answer · 2014-03-12 04:18:26Z

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<title>Insert title here</title>
</head>
<script>
var quotes = new Array()
quotes[0]="Simplicity is the ultimate sopistication";
quotes[1]="While I thought that I was learning how to live, I have been learning how to die.";
quotes[2]="The greatest deception men suffer is from their own opinions.";
quotes[3]="Art is never finished, only abandoned";
quotes[4]="Iron rusts from disuse; water loses its purity from stagnation. Even so does inaction sap the vigor of the mind.";

var randQuote=Math.floor(Math.random()*(quotes.length));
function showQuote(){
    document.getElementById("quotebox").innerHTML = quotes[randQuote];
}
</script>
<body onload="showQuote()">
    <div id="quotebox"></div>
</body>
</html>

This code runs well on my browser. May be some problem with your browser.

Collectives™ on Stack Overflow

Writing to a div from javascript

4 Answers 4

2 Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related