Simple program using loops (Beginning Java)

Question

I have to write a program using loops that calculates the sum of all odd numbers between a and b (inclusive), where a and b are inputs.

I made this (below) and it works fine, but I noticed one problem with it: when i enter a larger number followed by a smaller number for the inputs, it returns 0, but when i enter the smaller number first it works perfectly. Any quick fixes for this? :)

import java.util.Scanner;

public class ComputeSumAAndB
{

   public static void main (String[] args)
   {
       Scanner in = new Scanner(System.in); 
       System.out.print("Please enter 2 integers: "); //prompts user for ints
       int a = in.nextInt(); 
       int b = in.nextInt();
       int sum = 0;

       for (int j = a; j <= b; j++)
       {
           if (j % 2 == 1)
             sum += j;
       }
       System.out.println("The sum of all odd numbers (inclusive) between " + a + " and "+ b + " is " + sum);
   }
}

just two input not need to have for loop and you also can use array instead. — gjman2
– gjman2, Commented Nov 6, 2013 at 1:30
Use if (j % 2 == 1) it is not enough to check whether the num is odd. e.g a = -5, b =0; What will be the result? it is zero. You need to change the condition to if(!(j%2 == 0)) Then you will get the expected result. — Mengjun
– Mengjun, Commented Nov 6, 2013 at 2:10
This question has several good answers. You should consider marking one of them as accepted. — nhgrif
– nhgrif, Commented Nov 6, 2013 at 13:04

nhgrif · Accepted Answer · 2013-11-06 01:34:50Z

3

int temp;
if(a > b) {
    temp = a;
    a = b;
    b = temp;
}

Put this right before your for loop starts.

The if checks whether a (the first number entered) is larger than b. If it is, it swaps a and b. Now your for loop will always start with the smallest number and iterate up to the larger number (because after this if, a will always be the smaller number).

Using this method has the added side effect of making your output make sense. Your output will now always say: "between [smaller number] and [larger number]".

rolfl's answer is more elegant and works perfectly fine, but when the user enters the larger number first, your output may look kind of weird: "between [larger number] and [smaller number]", etc.

edited Nov 6, 2013 at 1:34

answered Nov 6, 2013 at 1:29

nhgrif

62.2k25 gold badges136 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rolfl · Accepted Answer · 2013-11-06 01:31:28Z

2

You can get the smaller and larger inputs by using the Math.min() and Math.max functions....

for (int j = Math.min(a,b); j <= Math.max(a,b); j++) {
    if (j % 2 == 1) {
        sum += j;
    }
}

answered Nov 6, 2013 at 1:31

rolfl

17.7k7 gold badges45 silver badges77 bronze badges

Comments

Logan Cunningham · Accepted Answer · 2013-11-06 01:31:20Z

0

It's not working because A is larger than B in the for loop, you have it iterate while A is less than or equal to B.

You could do what nhgrif says but it's changing your data.. But he is correct.

answered Nov 6, 2013 at 1:31

Logan Cunningham

306 bronze badges

Comments

Christian Tapia · Accepted Answer · 2013-11-06 01:32:57Z

0

That's because you are first expecting for the a input (inferior limit) and then the b (superior). When your program reaches the for, j = a so the condition a <= b is False, if the first input is larger. In other words it never enters the for loop.

answered Nov 6, 2013 at 1:32

Christian Tapia

34.2k7 gold badges58 silver badges73 bronze badges

Comments

Mengjun · Accepted Answer · 2013-11-06 01:52:27Z

0

Actually you should do the following 2 things:

1 It is just just like rolfl mentioned above. You need to put the min and max in the right place in loop.

for (int j = Math.min(a,b); j <= Math.max(a,b); j++) {

if (j % 2 == 1) {
    sum += j;
}

}

2 Use if (j % 2 == 1) it is not enough to check whether the num is odd.

e.g.

a = -5, b =0; What will be the result?

    int sum = 0;
    for(int j=-5;j<0;j++)
    {
        if(j%2 == 1)
        {
            sum+=j;
        }
    }

The value for sum will be 0.

We need to change the condition to if(!(j%2 == 0)) Then you will get the expected result.

answered Nov 6, 2013 at 1:52

Mengjun

3,1971 gold badge17 silver badges21 bronze badges

Comments

Jeffery Yuan · Accepted Answer · 2013-11-06 02:07:21Z

0

That's because you are first expecting for the a input (inferior limit) and then the b (superior). When your program reaches the for, j = a so the condition a <= b is False, if the first input is larger. In other words it never enters the for loop.

answered Nov 6, 2013 at 2:07

Jeffery Yuan

1491 silver badge4 bronze badges

Collectives™ on Stack Overflow

Simple program using loops (Beginning Java)

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related