foreach loop only display last element from array displayed

Question

I have a script that select a list of letter from the array but the problem is it only display the last element on the array.

PHP:

<?php

$letters = array("A", "B", "C");

foreach($letters as $letter)
{
    $data['#LETTER#'] = $letter;
}

$html = file_get_contents('test.html');

echo $html = str_replace(array_keys($data),array_values($data),$html);
?>

HTML:

<html>
<head>
<title>TRY</title>
</head>
<body>
<select>
<option>#LETTER#</option>
</select>
</body>
</html>

the output above the script is only C which is the last element in the array and I can only select the letter C not A B C

DESIRED OUTPUT: A B C

why is this happen? can anyone help? I appreciate with explanation. I'm currently new on php.

You assing every element to the same key in $data. Nemely the key "#LETTER#". On a second note, your method of outputting the array seems rather complex? — ToBe
– ToBe, Commented Nov 18, 2013 at 9:01

Mordalthunder · Accepted Answer · 2013-11-18 09:15:57Z

2

You should make it like this:

HTML:

<html>
<head>
<title>TRY</title>
</head>
<body>
<select>
#LETTER_SELECT#
</select>
</body>
</html>

PHP:

$letters = array("A", "B", "C");
$replace_select = "";
foreach($letters as $letter)
{
    $replace_select .= "<option>".$letter."</option>";
}

$html = file_get_contents("test.html");
echo $html = str_replace("#LETTER_SELECT#",$replace_select);

edited Nov 18, 2013 at 9:15

answered Nov 18, 2013 at 9:03

Mordalthunder

2561 silver badge3 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mordalthunder Over a year ago

what do you mean? you want 3 select options but only 1 option, that isn't possible.

Mordalthunder Over a year ago

You can't have 3 options into 1 option tag, for each select element you need another option tag.

Mordalthunder Over a year ago

Yes, but this will make the select tag only display 1 element

Mordalthunder Over a year ago

let us continue this discussion in chat

Harish Singh · Accepted Answer · 2013-11-18 09:18:52Z

1

try to use like. You have single key for all characters, you need to use string concat of php to make a string.

foreach($letters as $letter)
{
        $data['#LETTER#'] .= "<option value=$letter>".$letter."</option>";
}

<select>
#LETTER#
</select>

edited Nov 18, 2013 at 9:18

answered Nov 18, 2013 at 9:06

Harish Singh

3,3195 gold badges27 silver badges40 bronze badges

5 Comments

Darline Over a year ago

it just output ABC in one option it didn't make me selections :(

Harish Singh Over a year ago

concat space " " with it and finally use rtrim to remove last space

Harish Singh Over a year ago

define $data = array(); before foreach loop

Darline Over a year ago

is there no other way to remove option tag o the script?

Harish Singh Over a year ago

you can use this script in html between <select></select> tag with echo every line. But there is no way

Semi-Friends · Accepted Answer · 2013-11-18 09:10:28Z

0

i dont actually get what you're trying to do here, but it seems that your loop is always assign values to 1 element of array only, which is #LETTER#.. why not use

$data[] = $letter

instead and loop it inside the select tag

answered Nov 18, 2013 at 9:10

Semi-Friends

4806 silver badges17 bronze badges

Comments

Tullie Murrell · Accepted Answer · 2013-11-18 09:13:20Z

0

You are overwriting the array element in $data with each iteration.

You could implement the PHP within the HTML.

<select>

<?php
foreach($letters as $letter)
{
<option> $letter </option>
}
?>

</select>

answered Nov 18, 2013 at 9:13

Tullie Murrell

475 bronze badges

Comments

Jacek Lisiński · Accepted Answer · 2013-11-18 09:18:07Z

0

<?php

    $letters = array("A", "B", "C");

    foreach($letters as $letter)
    {
        $data['#LETTER#'] = $letter;
    }

    foreach ($data as $key => $value)
    {
        echo "Key: $key; Value: $value<br />\n";
    }

?>

Result:
Key: #LETTER#; Value: C

You have only one element in $data array. Try $data['#LETTER'.$letter.'#'] = $letter;

edited Nov 18, 2013 at 9:18

answered Nov 18, 2013 at 9:10

Jacek Lisiński

1232 silver badges6 bronze badges

1 Comment

ToBe Over a year ago

You might want to change your post from just showing the error to only showing a solution. Someone who just copies it will not archive anything here. (as op just did)

Collectives™ on Stack Overflow

foreach loop only display last element from array displayed

5 Answers 5

4 Comments

5 Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

5 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related