PHP Array shows only the last array item

Question

I have a foreach loop ($product_image) and an array ($newProductData), what I am trying to do is put the foreach content ($mediagalleryURLs) into the $newProductData array, when I print_r $newProductData, the the output shows only the last foreach element as $newProductData['media_gallery'] value, not the full elements, here is the code:

<?php
...

$resimURLNew = (string) $item->xpath('images/image[@main=1]')[0];

foreach($item->images->image as $product_image) {
    $mediagalleryURLs = $product_image.';';
    $mediagalleryURLs = rtrim($mediagalleryURLs, ';');
}

$newProductData = array(
    'sku'               => (string) $item->id,
    'barcode'           => (string) $item->barcode
);

$newProductData['image']       = (string) $resimURLNew;
$newProductData['small_image'] = (string) $resimURLNew;
$newProductData['thumbnail']   = (string) $resimURLNew;
$newProductData['media_gallery']   = $mediagalleryURLs;

...
?>

You are overwriting the $mediagalleryURLs on each iteration of the foreach loop. — M. Eriksson
– M. Eriksson, Commented Nov 5, 2015 at 14:24
Should @mediagalleryURLs be an Array or a semicolon separated string? — M. Eriksson
– M. Eriksson, Commented Nov 5, 2015 at 14:29

dev0 · Accepted Answer · 2015-11-05 14:25:06Z

1

You have to append the Urls:

foreach($item->images->image as $product_image) {
    $mediagalleryURLs .= rtrim($product_image) . ';';
}

answered Nov 5, 2015 at 14:25

dev0

1,0578 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

meda · Accepted Answer · 2015-11-05 14:22:36Z

0

You are overwriting the variable when you should be appending elements to your array:

$mediagalleryURLs = array();
foreach($item->images->image as $product_image) {
    $mediagalleryURLs[] = rtrim($product_image.';', ';');
}

answered Nov 5, 2015 at 14:22

meda

45.5k14 gold badges96 silver badges123 bronze badges

Comments

monirz · Accepted Answer · 2015-11-05 14:25:39Z

0

Try this,

 $newProductData = array(
    'sku'               => (string) $item->id,
     'barcode'           => (string) $item->barcode
);

foreach($item->images->image as $product_image) {
    $mediagalleryURLs = $product_image.';';
    $mediagalleryURLs = rtrim($mediagalleryURLs, ';');
    $newProductData['media_gallery']   = $mediagalleryURLs;
 }

 $newProductData['image']       = (string) $resimURLNew;
 $newProductData['small_image'] = (string) $resimURLNew;
 $newProductData['thumbnail']   = (string) $resimURLNew;

answered Nov 5, 2015 at 14:25

monirz

5445 silver badges14 bronze badges

Collectives™ on Stack Overflow

PHP Array shows only the last array item

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related