simple php code not working with ternary operator [duplicate]

Question

I'm quite a beginner when it comes to the ternary operators, never worked with them before.

Code (it was simplified)

$output2 = '
<div>
    <div>
        <span>test text1</span>
        <div>
            '.(1 == 1) ? "yes" : "no" .'
            <span>test text 2</span>
        </div> 
    </div>
</div>';
echo $output2;

So the problem is, this code only outputs "yes" (only the correct or false if statement)

I tried with "" same problem, tried with different conditions, tried just outputing it, without variables. But the problem remains.

yes, but it only returns "yes" and no "test text1" and "test text2" — Sebastjan
– Sebastjan, Commented Dec 1, 2013 at 16:45

Alexander Larikov · Accepted Answer · 2013-12-01 16:46:54Z

9

Surround your ternary if with brackets, i.e.

$output2 = '
<div>
    <div>
        <span>test text1</span>
        <div>
            '.((1 == 1) ? "yes" : "no") .'
            <span>test text 2</span>
        </div> 
    </div>
</div>';
echo $output2;

answered Dec 1, 2013 at 16:46

Alexander Larikov

2,33915 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

u_mulder · Accepted Answer · 2013-12-01 16:48:53Z

7

In php ternary operator behaves strangely, in your case:

(1 == 1) ? "yes" : "no" .'<span>test text 2</span>...'

yes is considered the first result, and "no" . <span>test text 2</span>... is the second result. To avoid such behaviour always use brackets

((1 == 1) ? "yes" : "no") .'<span>test text 2</span>...' // works correctly

answered Dec 1, 2013 at 16:48

u_mulder

54.8k5 gold badges54 silver badges72 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:25:12Z

2

Alexander's answer is correct, but I would go a little further and actually remove the ternary from the string.

$ternary = ($something == $somethingElse) ? "yes" : "no";

// Double brackets allows you to echo variables
//  without breaking the string up.
$output = "<div>$ternary</div>";

echo $output;

Doing it this way proves to be much easier to maintain, and reuse.

Here are a few uses for ternary operators. They're very powerful if you use them properly.

edited May 23, 2017 at 12:25

CommunityBot

11 silver badge

answered Dec 1, 2013 at 16:52

Labu

2,57230 silver badges34 bronze badges

Collectives™ on Stack Overflow

simple php code not working with ternary operator [duplicate]

3 Answers 3

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Linked

Related