ANDROID onTouchListener on button array

Question

I have put a lot of buttons (16*16) in a button array. The buttons numbers are directly related to changes they should do in another array (e.g. button[12][7] sets the value of stat[12][7] to 1)

So I thought it's possible to put on single line in the onTouch method that reacts to every button. Example (of course, not working)

public boolean onTouch(View arg0, MotionEvent arg1) {
if (arg1.getAction() == MotionEvent.ACTION_DOWN) {
if(arg0 == button[int a][int b]){stat[a][b]=1};

In this pseudocode, the button would create 2 ints that describe the 2 dimensions of the array which get passed to the stat array.

If anyone had a solution for this, he would save me a few hours this night.

Thanks for your answers.

Ismail Sahin · Accepted Answer · 2013-12-06 12:53:17Z

2

I think HasMap is a better solution

private HashMap<Integer,Button> btnMap = new HashMap<Integer, Button>();

private void init(){
    Button yourFirstBtn = (Button) findViewById(R.id.yourFirstBtn);
    btnMap.put(yourFirstBtn.getId(), yourFirstBtn);

    for(Button tempBtn: btnMap.values()){
        tempBtn.setOnClickListener(this);
    }
}

@Override
public void onClick(View v) {
// TODO Auto-generated method stub
    Button clickedBtn = btnMap.get(v.getId());
}

answered Dec 6, 2013 at 12:53

Ismail Sahin

2,7105 gold badges35 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2875404 Over a year ago

Thanks a lot, I already did sth different now, but I think, yours is a very intelligent solution!

Josh Li · Accepted Answer · 2013-12-06 12:41:12Z

2

Are you adding the onTouchListener to the buttons' container?

Your best bet is to add an onTouchListener to each button, and then arg0 will correspond to the specific button.

Another option would be to use a GridView, which has an setOnItemClickListener you can use. http://developer.android.com/reference/android/widget/GridView.html

answered Dec 6, 2013 at 12:41

Josh Li

1011 silver badge2 bronze badges

1 Comment

user2875404 Over a year ago

I am adding the onTouchListener to each of the buttons in a huge loop. A grid view would have the same amount of work I guess.

NigelK · Accepted Answer · 2013-12-06 12:57:14Z

2

As you add each button to the array, set a tag that indicates its indices. Tags are there for adding properties to a view without having to resort to another data structure.

For example:

button[12][7].setTag("12|7");

If your button were pre-defined in XML, you could do the same with:

android:tag="12|7"

Then in the touch listener (I assume the same one is attached to all the buttons), get the tag from the view that was touched:

String tag = (String) view.getTag();

Then substring out and use the two indexes as required:

String indx1 = tag.substring(0, tag.indexOf("|"));
String indx2 = tag.substring(tag.indexOf("|")+1);
stat[Integer.parseInt(indx1)][Integer.parseInt(indx2)] = 1;

answered Dec 6, 2013 at 12:57

NigelK

8,4902 gold badges33 silver badges30 bronze badges

Comments

damian · Accepted Answer · 2013-12-06 12:58:26Z

Try something like this:

Button[][] myButtonMatrix = new Button[] {
 new Button[] { button11, button12, button13, button 14 },
 new Button[] { button21, button22, button23, button24 }
};

public class MatrixButtonListener implements View.OnClickListener {
        private int x;
        private int y;

        public MatrixButtonListener(int x, int y) {
            this.x = x;
            this.y = y;
        }

        public int getX() { return x; }
        public int getY() { return y; }

        @Override
        public void onClick(View v) {
            stat[x][y] = x-y; // changes were made only in relation to x and y, nothing else
            // for example:
            if(x == 0) { 
                // button in first row
                // do something
            }
        }
    };

// to apply to each button in matrix:

for(int i=0; i<myButtonMatrix.length; i++) {
    for(int j=0; j<myButtonMatrix[i].length; j++) {
         myButtonMatrix[i][j].setOnClickListener(new MatrixButtonListener(i,j));
    }
}

What this is supposed to do:

Create a generic OnClickListener class, which takes the x and y position as parameter, so each onClickListener has the same behaviour, but differnet x and y positions, depending on the button itself.

Note: This is not tested.

EDIT:

Another way would be a custom button class, which you use, which contains the X/Y coordinates as well. Simply add onClickListener to each button, cast it back to your custom view, and ask for x/y.

Collectives™ on Stack Overflow

ANDROID onTouchListener on button array

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related