PHP functions nested foreach loop does not work

Question

Why doesn't this code work when i call it via function? It only works for the outer loop but the inner loop does not return values?

<?php populateEnrollment($products); ?>

<?php
function populateEnrollment($value){

    foreach($value as $productid => $prod) if ($productid ==101)
    { 
        echo '<tr>';
        echo '<td width=300 class="tah11">'. $prod["name"] .'</td>' ;
        echo '<td width=100 class="tah11"><div align="center"> <select name="enrollName"id="enrollNameId" >';
            foreach ($prod["membershipType"] as $type)
            {
                echo '<option value="' .$type["price"]; $typeIdPrice = $typeId["price"] .'">'.$type["name"] . ' at $' . $typeIdPrice . '</option>';
                echo '</select>';
                echo '</td>';                               
            } // end of foreach membershipTypen
    } // end of products foreach
} // end of function populateEnrollment
?>

Try print_r($prod["membershipType"]); to check whether it contains anything — 웃웃웃웃웃
– 웃웃웃웃웃, Commented Dec 20, 2013 at 10:51
Functions are mainly used for repetitive codes, I don't think this code is repetitive so why use a function? — Mr. Alien
– Mr. Alien, Commented Dec 20, 2013 at 10:52
Have you debug anything so far ? Check your output for print_r($prod["membershipType"]); before starting inner loop. — Rikesh
– Rikesh, Commented Dec 20, 2013 at 10:52
echo '<option value="' .$type["price"]; $typeIdPrice = $typeId["price"] .'">'.$type["name"] . ' at $' . $typeIdPrice . '</option>'; this line is problematic. your <option> tag will never be closed like this. — adamS
– adamS, Commented Dec 20, 2013 at 10:54
when you use a flow control without proper curly braces you're gonna have a bad time. Also, a kitten, a puppy and a bunny die horribly — STT LCU
– STT LCU, Commented Dec 20, 2013 at 10:57

user3122466 · Accepted Answer · 2013-12-20 11:14:16Z

2

Please add echo </select></td> out side your inner foreach loop.

Also the way you are echoing <option> is also wrong please check here

Changed $typeId to $type .. minor typo update

<?php
function populateEnrollment($value){

    foreach($value as $productid => $prod) if ($productid ==101){ 
    echo '<tr>';
    echo '<td width=300 class="tah11">'. $prod["name"] .'</td>' ;
    echo '<td width=100 class="tah11"><div align="center"> <select name="enrollName"id="enrollNameId" >';
    foreach ($prod["membershipType"] as $type){
           echo '<option value="' .$type["price"] .'">'.$type["name"] . ' at $' . $type["price"] . '</option>';

    } // end of foreach membershipTypen

    echo '</select>';
    echo '</td>';                               

    } // end of products foreach
} // end of function populateEnrollment
?>

edited Dec 20, 2013 at 11:14

user3122466

431 gold badge1 silver badge7 bronze badges

answered Dec 20, 2013 at 10:52

Parixit

3,8193 gold badges39 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Rikesh Over a year ago

Is this a answer ? Can you add your explanation if you have change or corrected anything in code posted by OP.

Parixit Over a year ago

@Rikesh Too hurry! I am doing that. :P

user3122466 Over a year ago

This worked ... so the reason why it did not work was because I was not echoing <option> properly ... Thanks a bunch .. I am new to PHP and I totally missed that!

Parixit Over a year ago

@user3122466 On left side of my answer you can see tick option.

user3122466 Over a year ago

I have a follow up question, should I ask it here or add a new question? It is related to updating a textbox with the value the user selects from the dropdown without refreshing the page or using the $GET

|

Muhammad Raheel · Accepted Answer · 2013-12-20 10:56:57Z

You can do it like this

<?php populateEnrollment($products); ?>

function populateEnrollment($value)
{

    foreach($value as $productid => $prod) 
    { 
        if ($productid ==101)
        {
            ?><tr><?php
            ?><td width=300 class="tah11"><?=$prod["name"]?></td><?php
            ?><td width=100 class="tah11"><div align="center">
                <select name="enrollName"id="enrollNameId" >
                <?php
                foreach ($prod["membershipType"] as $type)
                {
                    echo '<option value="' .$type["price"]; $typeIdPrice = $typeId["price"] .'">'.$type["name"] . ' at $' . $typeIdPrice . '</option>';
                }
            ?></td><?php
            ?></tr><?php
        }
    }
}

Collectives™ on Stack Overflow

PHP functions nested foreach loop does not work

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related