calling function in for and foreach loop failing in PHP

Question

I have an array on which I am iterating using for loop. The array has URL at each element that is needed to be passed as argument to a function.

When I call the function during iteration, loop stops after first iteration and does not proceed over entire array.

When I try to echo out only the value in array and does not call function in loop then it works fine.

This is the same issue if I use foreach loop. Please help.

Here is my code

echo '<ol>';
for($i=0; $i < count($watchList); $i++){
    saveProduct(getProductDetail($watchList[$i]));
    echo ' <li>Product Saved '. $watchList[$i] .'</li>';
}
echo '</ol>';

Do saveProduct or getProductDetail modify $watchList in any way? — Oliver Charlesworth
– Oliver Charlesworth, Commented Aug 13, 2011 at 20:45
288 items if i comment the function call and only echo out the following line after function I see all the iterations outputed. — Wikki
– Wikki, Commented Aug 13, 2011 at 20:46
getProductDetail is returning an array and saveProduct is executing SQL on MySql DB. saveProduct takes argument of associative array. — Wikki
– Wikki, Commented Aug 13, 2011 at 20:47

Michael Petrov · Accepted Answer · 2011-08-13 20:47:17Z

2

It's possible that the array is not sequential. You're assuming that it goes from 0-n, but that might not be the case. Use this and it should work:

echo '<ol>';
foreach($watchList as $key=>$watchItem){
    saveProduct(getProductDetail($watchItem));
    echo ' <li>Product Saved '. $watchItem .'</li>';
}
echo '</ol>';

answered Aug 13, 2011 at 20:47

Michael Petrov

2,31716 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

kjetilh · Accepted Answer · 2011-08-13 20:45:03Z

1

No problem with the loop. Must be something wrong with the functions you're calling.

Try turning on error reporting if you haven't already.

ini_set(‘error_reporting’, E_ALL);
ini_set(‘display_errors’, 1);`

answered Aug 13, 2011 at 20:45

kjetilh

4,9862 gold badges21 silver badges26 bronze badges

Comments

Hassan Khodadadeh · Accepted Answer · 2011-08-13 20:45:58Z

1

error_reporting(E_ALL );
ini_set('display_errors', '1');

Add code above to your code to see what's wrong?

foreach($watchList as $value){
    saveProduct(getProductDetail($value));
    echo ' <li>Product Saved '. $value .'</li>';

}

answered Aug 13, 2011 at 20:45

Hassan Khodadadeh

7,8984 gold badges47 silver badges72 bronze badges

1 Comment

Wikki Over a year ago

the astonishing thing is that in result of first iteration the data get saved in db but loop fails

Ease Technology · Accepted Answer · 2015-06-01 22:21:06Z

0

It's because your array key is not matching the value of $i in each iteration of the loop, presumably because your array keys are not sequential integers. No doubt the output (when you take the function call out) just prints 'Product Saved' as the $watchList[$i] is NULL.

You are simply trying to pass the value in the array to that function, so do it as follows and it won't matter what the keys are;

echo '<ol>';
foreach($watchlist as $key => $item){
    saveProduct(getProductDetail($item));
    echo ' <li>Product Saved '. $item .'</li>';
}
echo '</ol>';

answered Jun 1, 2015 at 22:21

Ease Technology

663 bronze badges

Collectives™ on Stack Overflow

calling function in for and foreach loop failing in PHP

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related