Passing php-variable with JavaScript and HTML-Form

Question

I am trying to create a Delete-button with a user confirmation-pop-up.

HTML/PHP:

<form method='POST' onclick='return confirmDelete()'>
  <button type='submit'>
    Delete script
  </button>
</form>

JavaScript:

<script type="text/javascript">
function confirmDelete() {
if (confirm("Are you sure?")) {
  window.location.href = 'delete_script.php?<?php echo "$id" ?>';
  return false;
}
else{
  return true;
  }
}
</script>

What it does is that it re-directs me to the correct page, "delete_script.php" but the $id does not appear in the url. The "delete_script.php"-page works with other pages, but I don't know what's wrong with this code. I really think it's possible. Any help would be appreciated!

This looks od <?php echo "$id" ?>. If $id is a variable remove the double quotes. You also might want to add a query string name for example 'delete_script.php?id=<?php echo $id ?>'. — synapze
– synapze, Commented Jan 5, 2014 at 23:14
You could just keep it in a $_SESSION[''] varible... that way it's global... everywhere . — ilarsona
– ilarsona, Commented Jan 5, 2014 at 23:25
I did try to keep it in a $_SESSION variable, but it wouldn't get into the url anyway. And I'd prefer to do it this way. I have excluded alot of code, the $id is the id of a post in my database. This page gets it from $_GET from another page. — simeg
– simeg, Commented Jan 5, 2014 at 23:27

Ja͢ck · Accepted Answer · 2014-01-05 23:24:59Z

1

You're expected to pass a url-encoded value for the query-string:

<?php echo 'id=' . urlencode($id); ?>

Alternatively, generate the whole url in php:

location.href = <?php echo json_encode('delete_script.php?id=' . urlencode($id)); ?>;

answered Jan 5, 2014 at 23:24

Ja͢ck

174k39 gold badges269 silver badges316 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

simeg Over a year ago

The alternative answer worked perfectly! Thank you very much, sir.

synapze · Accepted Answer · 2014-01-05 23:19:12Z

1

As per my comment, change this...

if (confirm("Are you sure?")) {
  window.location.href = 'delete_script.php?<?php echo "$id" ?>';
  return false;
}

to this..

if (confirm("Are you sure?")) {
  window.location.href = 'delete_script.php?id=<?php echo $id ?>';
  return false;
}

answered Jan 5, 2014 at 23:19

synapze

2511 silver badge8 bronze badges

1 Comment

simeg Over a year ago

No difference, thanks though. Just re-directing me to the page without any $id in the url.

Collectives™ on Stack Overflow

Passing php-variable with JavaScript and HTML-Form

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related