Using using in a constructor

Question

I am using a create method for a constructor of a converter.

public void loadData()
{
    byte [] data = new byte [] {......}; // some byte data in here
    var converter = GetDataConverter(data);
}

Now inside the GetDataConverter I need to create a memorystream from the binary data (the converter is 3rd party and takes a stream) If I write the GetDataConverter like this I get an error telling me I didnt' dispose which I understand. I created a MemoryStream and I need to dispose.

public MyDataConverter GetDataConverter(byte [] data)
{
    return new MyDataConverter(new MemoryStream(data));
}

So my solution would be this:

public MyDataConverter GetDataConverter(byte [] data)
{
    using(var ms = new MemoryStream(data))
    {
       return new MyDataConverter(ms);
    }
}

The question is, is my solution correct? Should I be using a 'using' here? isn't the 'using' going to destroy my memory stream once it's out of scope so the converter will have nothing to work on?

I need an answer AND an explanation please, I'm a bit vague on the whole 'using' thing here.

Thanks

´MyDataConverter´ should implement ´IDisposable´ and take care of disposing the ´MemoryStream´. — Alessandro D'Andria
– Alessandro D'Andria, Commented Jan 15, 2014 at 11:55
@vape: That one doesn't really answer my question. I want to know how will the 'using' affect the rest of my converter if I call it around the constructor. — user3177615
– user3177615, Commented Jan 15, 2014 at 11:56
@user3177615 use solution which Alessandro suggests (actually I think it worth being posted as answer) — Sergey Berezovskiy
– Sergey Berezovskiy, Commented Jan 15, 2014 at 11:57
@user3177615 because it uses disposable resource. When resource is not needed anymore, it is responsibility of resource user to clean up that resource. Rule of thumb is following - if your class uses IDisposable resource, then class should be IDisposable also — Sergey Berezovskiy
– Sergey Berezovskiy, Commented Jan 15, 2014 at 12:01

Alessandro D'Andria · Accepted Answer · 2014-01-15 12:16:54Z

0

If you have no access to the code of ´MyDataConverter´ and the type doesn't implements ´IDisposable´ you can do:

public void loadData()
{
    byte[] data = new byte[] { 0 }; // some byte data in here

    using (var stream = new MemoryStream(data))
    {
        var converter = new MyDataConverter(stream);

        // do work here...
    }
}

If you have to use this many times and want to reuse your code you can do something like this:

public void loadData()
{
    byte[] data = new byte[] { 0 }; // some byte data in here

    UsingConverter(data, x =>
    {
        // do work here...
    });
}

void UsingConverter(byte[] data, Action<MyDataConverter> action)
{
    using (var stream = new MemoryStream(data))
    {
        var converter = new MyDataConverter(stream);

        action(converter);
    }
}

answered Jan 15, 2014 at 12:16

Alessandro D'Andria

8,8882 gold badges39 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Henrik · Accepted Answer · 2014-01-15 12:16:16Z

0

It really depends on the implementation of MyDataConverter. If the MemoryStream is only used inside the constructor to retrieve some data from it, then your solution with using is OK. If, OTOH, MyDataConverter keeps a reference to the MemoryStream to access it later, you must not dispose it here.

answered Jan 15, 2014 at 12:16

Henrik

23.3k6 gold badges44 silver badges93 bronze badges

Collectives™ on Stack Overflow

Using using in a constructor

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related