Sorting a randomized array in Java

Question

I am trying to make an app for sorting a randomized array I made some code and I can not see what is wrong with it that it returns wrong values Notes: I am trying to learn programming. So don't suggest whole different ways of solving the problem. I just want to see what is wrong with this code so I can get better. What RandomArrayCreator.create() returns is just an array of numbers in randomized order.

public class ArraySorter
{
public static void main(String[] args)
{
    int[] siyahi = RandomArrayCreator.create();
    int[] siralanmish = new int[siyahi.length];

    for (int i=0;i<siyahi.length;i++)
    {
        for (int j=0;j<siyahi.length;j++)
        {
            for (int k=j+1;k<siyahi.length;k++)
            {
                if (siyahi[k]<siyahi[j]) j=k;
            }
            siralanmish[i]=siyahi[j];
            siyahi[j]=siyahi.length+1;
        }
        System.out.println(siralanmish[i]);
    }
}

}

This siyahi[j]=siyahi.length+1; looks suspiouis

MadProgrammer
– MadProgrammer

2014-03-25 01:03:05 +00:00
Commented Mar 25, 2014 at 1:03 — MadProgrammer
– MadProgrammer, Commented Mar 25, 2014 at 1:03
Well... what sorting method are you trying to implement?

Dyrborg
– Dyrborg

2014-03-25 01:14:58 +00:00
Commented Mar 25, 2014 at 1:14 — Dyrborg
– Dyrborg, Commented Mar 25, 2014 at 1:14
What type of sort uses three nested loops?

David Ehrmann
– David Ehrmann

2014-03-25 01:20:58 +00:00
Commented Mar 25, 2014 at 1:20 — David Ehrmann
– David Ehrmann, Commented Mar 25, 2014 at 1:20
What are these variable names?

Bruno Toffolo
– Bruno Toffolo

2014-03-25 01:29:13 +00:00
Commented Mar 25, 2014 at 1:29 — Bruno Toffolo
– Bruno Toffolo, Commented Mar 25, 2014 at 1:29

Gabs00 · Accepted Answer · 2014-03-25 01:49:59Z

1

I know you did not want suggestions but I'm going to offer one anyway.

Hopefully this will help guide you along the way, but still allow you to come up with your own solution.

Sort smallest to biggest.

did I have swap an element?
while I swapped an element
    assume I did not swap an element
    for element i in the array
        is i > i+1?
            if yes 
                swap the elements
                I did swap an element
            else
                do nothing

answered Mar 25, 2014 at 1:49

Gabs00

1,8771 gold badge13 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andy Niles · Accepted Answer · 2014-03-25 01:39:07Z

Given that you mentioned you wanted to learn how to improve your current program, here are minimalist changes that will have your code produce a sorted array.

A few notes on the changes:

1.

if (siyahi[k]<siyahi[j]) j=k;

This I assume is for trying to swap the values at each indexes. Instead you are assigning the value of k to j which will cause problems with the entire for loop. I replaced this with the following:

    if (siyahi[k]<siyahi[j]) 
    {
        int temp = siyahi[j];
        siyahi[j] = siyahi[k];
        siyahi[k] = temp;
    }

This creates a temporary variable to store one of the values so that you can swap the value at each index without losing one of your values.

2.

siralanmish[i]=siyahi[j];

This was replaced with:

siralanmish[j]=siyahi[j];

This allows you to directly copy the values from the same index from the source array to the target array.

3.

siyahi[j]=siyahi.length+1;

This code will just fill up your array with the value of length+1 for your original array and you will lose your other values.

Your code with the fixes are below:

    public class ArraySorter
    {
    public static void main(String[] args)
    {
        int[] siyahi = RandomArrayCreator.create();
        int[] siralanmish = new int[siyahi.length];

        for (int i=0;i<siyahi.length;i++)
        {
            for (int j=0;j<siyahi.length;j++)
            {
                for (int k=j+1;k<siyahi.length;k++)
                {
                    if (siyahi[k]<siyahi[j]) 
                    {
                      int temp = siyahi[j];
                      siyahi[j] = siyahi[k];
                      siyahi[k] = temp;
                    }
                }
                siralanmish[j]=siyahi[j];
            }
            System.out.println(siralanmish[i]);
        }
    }

Thanks a lot, it works. But when I try this code, I get an error like "reached end of file while parsing", any idea why?

Collectives™ on Stack Overflow

Sorting a randomized array in Java

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related