javascript - removing an array element

Question

I'll pseudocode this to begin:

array = copper, oil, silver, bronze, gold, iron

user inputs the letter 'l'

if (the input has the letter 'l', remove everything from the array except words with 'l') {

output = copper, bronze, iron

my code:

//arr = iron, oil, gold, silver, bronze

classDiv = document.getElementsByClassName("searchOutputName");

for(var i = 0; i < arr.length; i++){

   market = arr[i];

   var n = market.indexOf(userInput.value);

      if (n >= 0) {
      classDiv[i].appendChild(document.createTextNode(arr[i]));

}
else {
      //do nothing
}

I have 5 div boxs for my search function.

If the user inputs 'l' the first box is empty, then it says oil, gold, silver, then another empty box. I want to make it so they stack up... first box has oil, then gold, then silver then 2 empty boxs.

Can you clarify your question? Are you looking to remove an array element or limit the DOM nodes that you create? Also, can you create a JSFiddle that demonstrates the problem that you're seeing, because the code that you provided would not do what you've describe. — Dancrumb
– Dancrumb, Commented Mar 29, 2014 at 18:42
Why not use jquery autocomplete? Should do what you need unless you can't use jquery — juvian
– juvian, Commented Mar 29, 2014 at 18:45

Raul Guiu · Accepted Answer · 2014-03-29 18:52:28Z

3

You also could use filter for the javascript:

var arr = ["copper", "oil", "silver", "bronze", "gold", "iron"];
arr = arr.filter(function(item){ return item.indexOf('l')>=0;});
console.log(arr);

answered Mar 29, 2014 at 18:52

Raul Guiu

2,41423 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Praveen · Accepted Answer · 2014-03-29 18:59:49Z

1

Though I have not added html to your code, I have managed to do it with JS which can be reworked to fit your need.

var arr = ["copper", "oil", "silver", "bronze", "gold", "iron"];

for (var i = 0; i < arr.length; i++) {
    if (arr[i].indexOf('l') !== -1) {
        arr.splice(i, 1); // Remove the element from array
        i = i - 1;  // Equalize to manage the removed array length
    }
}
console.log(arr);  //returns ["copper", "bronze", "iron"]

JSFiddle (Based on the pseudocode you have posted)

edited Mar 29, 2014 at 18:59

answered Mar 29, 2014 at 18:45

Praveen

56.7k35 gold badges137 silver badges169 bronze badges

Comments

Ryan Buckley · Accepted Answer · 2014-03-29 18:51:59Z

0

Sounds like you just want to sort the array by the elements that match the user input. How about something like this?

var text = 'l', t = ['iron', 'oil', 'gold', 'silver', 'bronze']
t.sort(function(a, b) { return a.indexOf(text) < b.indexOf(text) })
// => ["oil", "gold", "silver", "iron", "bronze"]

answered Mar 29, 2014 at 18:51

Ryan Buckley

1063 bronze badges

1 Comment

Praveen Over a year ago

You should again need to take a look at the pseudocode of OP's.

pid · Accepted Answer · 2014-03-29 18:52:47Z

0

This is the code you should use. It works, contrary to the other answer which has a bug.

function filter(items, criteria)
{
  var i, result;

  result = [];
  for (i = 0; i < items.length; i++)
  {
    if (items[i].indexOf('l') !== -1)
    {
        result.push(items[i]);
    }
  }

  return result;
}

You can filter by the criteria this way:

// market  = [ 'copper', 'oil', 'silver', 'bronze', 'gold', 'iron' ];
// userInput = '1';

subset = filter(market, userInput);

answered Mar 29, 2014 at 18:52

pid

11.6k6 gold badges37 silver badges67 bronze badges

4 Comments

Raul Guiu Over a year ago

Why you have to write the filter yourself? You have it already in JS.

pid Over a year ago

Oh really? I can't recall it, what are you referring to?

Raul Guiu Over a year ago

developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/…

pid Over a year ago

I see. That's ES5 while full cross-browser compatibility (esp. older browsers like IE6) require a polyfill.

Collectives™ on Stack Overflow

javascript - removing an array element

4 Answers 4

Comments

JSFiddle (Based on the pseudocode you have posted)

Comments

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

JSFiddle (Based on the pseudocode you have posted)

Comments

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related