Javascript String replace "'"

Question

How do I replace ' in javascript. For example I want to convert O'conor to O-conor. This doesnt work. I am doing something stupid.

var dummyStr =  "O'conor";
dummyStr.replace("'","-");
console.log(dummyStr); //prints O'conor 
dummyStr.replace(/'/g,"-"); //still prints O'conor not O-conor

Please mark duplicate if this has already been asked elsewhere.

possible duplicate of Why does the Javascript replace() function not do anything? — Bergi
– Bergi, Commented Apr 15, 2014 at 6:58
you are doing right but you have to save value of dummyStr.replace("'","-"); in varible, you can do like this dummyStr = dummyStr.replace("'","-"); — Himanshu
– Himanshu, Commented Apr 15, 2014 at 6:59
exact duplicate of stackoverflow.com/questions/1433212/replace-method-doesnt-work — Bergi
– Bergi, Commented May 21, 2014 at 22:16

Samuel Caillerie · Accepted Answer · 2014-04-15 06:57:21Z

7

replace (cf. replace on W3Schools) does not modify the current string. You have to assign it like this :

dummyStr = dummyStr.replace("'","-");
console.log(dummyStr); //prints O-conor

answered Apr 15, 2014 at 6:57

Samuel Caillerie

8,2652 gold badges29 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

lonelymo Over a year ago

i feel like a moron! Thanks

Samuel Caillerie Over a year ago

No worry, that's a common issue :-)

dougajmcdonald · Accepted Answer · 2014-04-15 06:58:04Z

3

You need to assign a variable to the return value of replace()

e.g.

var dummyStr =  "O'conor";
var ammendedString = dummyStr.replace("'","-");
console.log(ammendedString );

answered Apr 15, 2014 at 6:58

dougajmcdonald

20.2k12 gold badges61 silver badges100 bronze badges

2 Comments

lonelymo Over a year ago

feel like a moron! Thanks

dougajmcdonald Over a year ago

No problems, it's easy to miss things like that, at a more fundamental level, try to remember that strings in JavaScript are immutable, so you can't 'change' them as such, you generally need to run functions against them and either assign the result to something else, or back to the original variable.

Bhushan Kawadkar · Accepted Answer · 2014-04-15 06:57:57Z

3

you just need to store this to some variable after replace, like below

dummyStr = dummyStr.replace("'","-");

answered Apr 15, 2014 at 6:57

Bhushan Kawadkar

28.6k5 gold badges39 silver badges61 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:51:11Z

3

dummyStr = dummyStr.replace("'","-");

Btw for replacing all: Replace All - StackOverFlow

edited May 23, 2017 at 11:51

CommunityBot

11 silver badge

answered Apr 15, 2014 at 7:00

Amir Popovich

30.1k9 gold badges58 silver badges102 bronze badges

Collectives™ on Stack Overflow

Javascript String replace "'"

4 Answers 4

2 Comments

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related