Remove element from array unless has a certain value in Rails

Question

I have an array of "names" and I would like to display the current user's name ONLY IF there it is the only name in the array. If there are other names in the array, I don't want to show the current user's name.

Currently, I am listing the names and excluding the current user's name, but don't want to exclude the current user's name if it is the only one in the array. I hope I explained that okay.

My code now:

module ConversationsHelper

def other_user_names(conversation)

    users = []
    conversation.messages.map(&:receipts).each do |receipts|
        users << receipts.select do |receipt|
            receipt.receiver != current_user
        end.map(&:receiver)

    end
    users.flatten.uniq.map(&:name).join ', '

end
end

First collect all receivers, then check against current user. — Sergio Tulentsev
– Sergio Tulentsev, Commented Jun 26, 2014 at 7:41

Stefan · Accepted Answer · 2014-06-26 08:03:35Z

5

This should work:

def other_user_names(conversation)
  # get all users (no duplicates)
  users = conversation.messages.map(&:receipts).map(&:receiver).uniq

  # remove current user if there are more than 1 users
  users.delete(current_user) if users.many?

  # return names
  users.map(&:name).join(', ')
end

I would move the first line into a Conversation#users method.

answered Jun 26, 2014 at 8:03

Stefan

115k14 gold badges157 silver badges233 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user2756384 Over a year ago

Thanks for the help, much appreciated. I'm confused as to what you mean by moving the first line.. Are you saying move the helper into the controller, or take the other_user_names and put that in the conversations controller? Thanks again.

user2756384 Over a year ago

When I replaced my method with yours (still in the helper), I get this error: undefined method `receiver' for #<Mailboxer::Receipt::ActiveRecord_Associations_CollectionProxy:0x007fc1b9fdf9f8>

Stefan Over a year ago

@user2756384 Not the helper itself, but the helper's first line, i.e. `users = conversation.messages.map(&:receipts).map(&:receiver).uniq

Stefan Over a year ago

Could you post your associations from Conversation to User, please?

user2756384 Over a year ago

I'm using the mailboxer Gem. I'm not exactly sure how the assocations work.

Collectives™ on Stack Overflow

Remove element from array unless has a certain value in Rails

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related