Error due to single quote ' in javascript function call

Question

I am passing value dynamically to javascript function.

I am retrieving data from database and filling to javascript function, it does not have a static binding.

share_it(data_from_mysql_database);

like

share_it('value from mysql database');

Some times value contain a single quote (').

like: share_it(' Essentially you'll have to have a good academic history ');

So function call gives error that:

Uncaught SyntaxError: Unexpected identifier

before passing the string into function simply replace the ' with \' using regex — Unknownman
– Unknownman, Commented Jul 26, 2014 at 5:41

cdhowie · Accepted Answer · 2014-07-26 05:34:02Z

2

You can use the \ character to escape such characters:

share_it(' Essentially you\'ll have to have a good past academic ');

Or, you can switch to using double quotes if you know you will need to embed a single quote character:

share_it(" Essentially you'll have to have a good past academic ");

answered Jul 26, 2014 at 5:34

cdhowie

172k25 gold badges303 silver badges324 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hitesh Modha Over a year ago

i am passing value dynamically from database

cdhowie Over a year ago

@HiteshModha If you mean that you are building JavaScript code dynamically, then you will need to process the string yourself to add the required escape characters. How you accomplish this depends on the language you are using to build the JavaScript.

Jongware · Accepted Answer · 2014-07-26 05:36:16Z

2

You can freely switch between double " and single ' quotes where you need the other in a literal string:

share_it(" Essentially you'll have to have a good past academic ");

Only in cases where you need both, you need to escape the repeating character:

share_it(" Essentially you'll have to have a good \"past\" academic ");

answered Jul 26, 2014 at 5:36

Jongware

22.6k8 gold badges56 silver badges104 bronze badges

Comments

Edward · Accepted Answer · 2014-07-26 05:42:17Z

1

You can also replace the ' in the string with &#39.

answered Jul 26, 2014 at 5:42

Edward

798 bronze badges

Comments

Ryan · Accepted Answer · 2014-07-26 05:48:19Z

-1

You ought to be converting special chars on the upstream rather than the downstream. Converting it on the upstream saves time later when an inexperienced developer does not care to escape the data on the downstream when sent to the client. Since you have not properly converted the data on the upstream, you have no choice. You should escape it.

share_it(escape(data_from_mysql_database));

Example"

> escape("You're awesome");
'You%27re%20awesome'
>

edited Jul 26, 2014 at 5:48

answered Jul 26, 2014 at 5:42

Ryan

14.7k9 gold badges68 silver badges104 bronze badges

2 Comments

Mr. Shiny and New 安宇 Over a year ago

Are you suggesting that the DB shouldn't store apostrophes or single quotes in case someone wants to output some data as a JS string literal? Also, what's with the %xx escaping in the JS string? Shouldn't you escape it with a \ instead?

Mr. Shiny and New 安宇 Over a year ago

The escape function is meant for encoding url parameter values. It's not meant for turning raw text into JS string literals. With this function, his code will run but it won't work properly. The proper solution is to replace all ' or " with \' or \". Yes it needs to be done "manually" whenever he writes raw data to JS.

Collectives™ on Stack Overflow

Error due to single quote ' in javascript function call

4 Answers 4

2 Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related