problem with sql query, variable value not inserting itself

Question

the old query works, the new on doesnt. the android logcat gives me error as: Failure 1: no such column abcname. abcname is the value of a editview that im trying to get from a popup in android.

i know that the first query will insert those values in the fields, as they are given in single inverted commas. the same query, i typed in the adb shell, works. so i copied the query, and just removed the data corresponding to the field names, and inserted the variable names. on trying to run, i get the above said error.

OLD QUERY:

MapsActivity.myDB.execSQL("INSERT INTO "
    +MapsActivity.TableName
    + " (name, user_comment, latitude, longitude) "
    + " VALUES ('tagName','tagComment','tagLatitude','tagLongitude');");

NEW QUERY:

MapsActivity.myDB.execSQL("INSERT INTO "
    +MapsActivity.TableName
    + " (name, user_comment, latitude, longitude) "
    + " VALUES ("+tagName +",'tagComment','tagLatitude','tagLongitude');");

what is the problem?

Marcelo Cantos · Accepted Answer · 2010-03-27 10:11:51Z

1

If tagName has, e.g., the value "abc", your query will expand to ... VALUE (abc,'tagComment',.... It's missing the single quotes.

Building SQL like this give bad karma. Use SQLite's parameter-binding mechanism instead.

answered Mar 27, 2010 at 10:11

Marcelo Cantos

187k40 gold badges338 silver badges366 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kaustubh Over a year ago

@1 the old query works fine. its the second query that doesnt work. i have to take the value from a varible, hence i cant use a single quote. i need to substitute the value oftagName. @2 looking into parameter-binding thnx!

CommonsWare Over a year ago

Even better: use the insert() method on SQLiteDatabase, so you are not generating any of your own SQL.

Dave.B · Accepted Answer · 2010-03-27 17:59:23Z

0

I recommend creating a simple active record db implementation. here is a great tutorial for a simple sqlite active record for android. This adds some extra time up front but saves you time while you develop.

answered Mar 27, 2010 at 17:59

Dave.B

6,6621 gold badge21 silver badges20 bronze badges

Comments

searchMaker · Accepted Answer · 2010-03-27 18:53:04Z

0

wrap your double quotes with single quotes?

...('"+tagName +"',....

answered Mar 27, 2010 at 18:53

searchMaker

431 gold badge1 silver badge4 bronze badges

1 Comment

Kaustubh Over a year ago

nope, pretty confusing. im trying to declare the queries, fields, and the values, as a string, with value substitution. lets see where that take me.

Collectives™ on Stack Overflow

problem with sql query, variable value not inserting itself

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related