Android SQL INSERT statement using variables problem

Question

I have a problem with an SQL INSERT statement. I am trying to insert data stored in Strings but this always throws an error.

private final String HASH_DB = "hashDb";
private final String HASH_TABLE2 = "newHashes";

SQLiteDatabase hashDB = null;

hashDB = this.openOrCreateDatabase(HASH_DB, MODE_PRIVATE, null);

hashDB.execSQL("CREATE TABLE IF NOT EXISTS " + HASH_TABLE2
    + " (dialogID INT, Filename VARCHAR, Hash VARCHAR);");

hashDB.execSQL("INSERT INTO " + HASH_TABLE2 +" (dialogID, Filename, Hash) "
   + " Values (dialogID, filename, newHash);");

dialogID is an int, and Filename and Hash are both Strings, I have confirmed that the correct data is stored in these by displaying them in a Toast.

The above throws an error but if I change the last line to this below, i.e hardcoding the data to be inserted it works.

hashDB.execSQL("INSERT INTO " + HASH_TABLE2 +" (dialogID, Filename, Hash) "
   + " Values (4, 'filename', 'newHash');");

How can I get this working?

Many Thanks

Matt

Killerwes · Accepted Answer · 2011-07-27 12:19:21Z

5

I haven't really worked with Android, but are those files not files variables?

Shouldn't it be

hashDB.execSQL("INSERT INTO " + HASH_TABLE2 +" (dialogID, Filename, Hash) "
   + " Values (" + dialogID + ", '" + filename + "', '" + newHash + "');");

edited Jul 27, 2011 at 12:19

answered Jul 27, 2011 at 12:10

Killerwes

2921 gold badge4 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jacob Over a year ago

you are missing quotes around filename and newHash in the query

Jacob · Accepted Answer · 2011-07-27 12:13:31Z

3

You need to close the string quotes and add your variables on your Insert statement. Something like this;

hashDB.execSQL("INSERT INTO " + HASH_TABLE2 +" (dialogID, Filename, Hash) "
   + " Values (" + dialogID + ", '" + filename + "', '" + newHash + "');");

Assuming you have the three variables (dialogID, filename and newHash) defined elsewhere.

edited Jul 27, 2011 at 12:13

Jacob

43.6k6 gold badges81 silver badges81 bronze badges

answered Jul 27, 2011 at 12:13

CodeChimp

4,8646 gold badges48 silver badges62 bronze badges

Comments

Ovidiu Latcu · Accepted Answer · 2011-07-27 12:17:36Z

2

You are passing wrong the parameters to the query.

You should do this in the following way:

    " Values(" + dialogId +", " +filename +", " + newHash +");"

or you should use

    public long insert (String table, String nullColumnHack, ContentValues values)

Example:

ContentValues values = new ContentValues();
values.put("dialogId", dialogId);
values.put("filename", filename);
values.put("newHash", newHash);
mDatabase.insert("your_table", null, values);

answered Jul 27, 2011 at 12:17

Ovidiu Latcu

72.4k15 gold badges78 silver badges86 bronze badges

Collectives™ on Stack Overflow

Android SQL INSERT statement using variables problem

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related