git add multiple files from bash array

Question

I want to add filenames/path to a git commit. I have the file path in a array but when i commit I get:

fatal: pathspec 'dist/core.js dist/style.css bower.json Source/core.js' did not match any files

Earlier in my script I have:

DIR=`dirname "$0"`
for file in "${COREFILES[@]}"; do echo $file="$DIR/$file"; done
for file in "${JSONFILES[@]}"; do echo $file="$DIR/$file"; done
TARGET_FILES=$(IFS=$' '; echo "${TARGET_FILES[*]}")
TARGET_FILES=( "${COREFILES[@]}" "${JSONFILES[@]}" )

and the error line is:

sh -c "cd $DIR && git add '$TARGET_FILES' && git commit -qm 'Current tag $TAG$SUFFIX.'"

Other parts of the script that change the source code in files works good. When I do echo $TARGET_FILES I get a string, space separated and looks all ok...

Any pointer what I could be missing? or how to do this otherwise?

konsolebox · Accepted Answer · 2014-08-16 15:00:20Z

2

git add '$TARGET_FILES'

should be

git add "${TARGET_FILES[@]}"

And this line does nothing and is probably not helpful:

TARGET_FILES=$(IFS=$' '; echo "${TARGET_FILES[*]}")

Also I don't think you should use sh -c:

cd "$DIR" && git add "${TARGET_FILES[@]}" && git commit -qm "Current tag $TAG$SUFFIX."

As a whole:

DIR=$(dirname "$0")
for file in "${COREFILES[@]}"; do echo "$file=$DIR/$file"; done
for file in "${JSONFILES[@]}"; do echo "$file=$DIR/$file"; done
TARGET_FILES=( "${COREFILES[@]}" "${JSONFILES[@]}" )
cd "$DIR" && git add "${TARGET_FILES[@]}" && git commit -qm "Current tag $TAG$SUFFIX."

answered Aug 16, 2014 at 15:00

konsolebox

76.3k13 gold badges110 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Rikard Over a year ago

Interesting ( and thank you for fast answer!). So git add "${TARGET_FILES[@]}" is the right way and also "makes the array into a string" like I had here: TARGET_FILES=$(IFS=$' '; echo "${TARGET_FILES[*]}"). Did I understand right?

konsolebox Over a year ago

@Rikard git add adds one file per argument so you have to pass multiple arguments, not a single string. Are you passing the command to ssh?

Rikard Over a year ago

Ok, so "${TARGET_FILES[@]}" is parsed as multiple arguments? so I was doing a single argument with a string.

konsolebox Over a year ago

Yes it cleanly expands to multiple arguments. Even spaces on elements are preserved.

Collectives™ on Stack Overflow

git add multiple files from bash array

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related