php While Loop causing Duplicate results

Question

For some reason my php while loop is printing out the data twice and I cannot seem to figure why this is. Here is my code:

<?php
$json = '[';
$query  = "SELECT user_id, first_name, last_name, phone, phone_two, email FROM customers LIMIT 20";
$result = mysqli_query($dbc, $query);
while($row = mysqli_fetch_array($result, MYSQLI_BOTH)) {
    $json .= "{ num: \"{$row['user_id']}\" },{ num: \"{$row['first_name']}\" },{ num: \"{$row['last_name']}\" },{ num: \"{$row['phone']}\" },{ num: \"{$row['phone_two']}\" },{ num: \"{$row['email']}\" },";
}

//Remove the last trailing comma
$json .= substr($json, 0, -1);

$json .= ']';

echo $json;
?>

When I echo the results out to the web browser, instead of having 20 customers, I have 40. However, it is the first 20 customers listed twice. I have no clue what could be causing this to happen.

Why are you doing all of that? Just build a PHP array in your loop and then use json_encode. — AbraCadaver
– AbraCadaver, Commented Aug 16, 2014 at 16:32
i agree with using the standard json_encode method. likewise it would be better to use rtrim($json, ',') just in case there isn't a trailing , (like when no users are returned) — xeo
– xeo, Commented Aug 16, 2014 at 17:09

Gaurav Bhor · Accepted Answer · 2014-08-16 17:05:29Z

1

Drop the .= for =

So, your statement

$json .= substr($json, 0, -1);

becomes

$json = substr($json, 0, -1);

edited Aug 16, 2014 at 17:05

Gaurav Bhor

1,1672 gold badges11 silver badges26 bronze badges

answered Aug 16, 2014 at 16:10

user1961026

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

php While Loop causing Duplicate results

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related