creating custom" string " (struct) copy

Question

Im trying to create a function to copy my card struct. im starting off easy with just copying the cvalue. however, my cvalue isnt copying, it is still reading 5 when should read 1000.

#include <iostream>
#include <fstream>
#include <ctime>
#include <stdlib.h>
#include <string>

using namespace std;

//Structs
struct card 
{
    char suit[8];
    char rank[6];
    int cvalue;
    char location;
};

void copyCard(card destination, card source);

int main()
{
    card card1;
    card card2;
    card1.cvalue = 1000;

    card2.cvalue = 5;
    card *card1p = &card1;

    copyCard(card2, card1);
    cout << card2.cvalue << endl;

}

void copyCard(card destination, card source)
{
    card *myPointer;
    myPointer = &source;
    (*myPointer).cvalue = source.cvalue;
    myPointer = &destination;
    destination.cvalue = (*myPointer).cvalue;
}

user3920237 · Accepted Answer · 2014-09-18 06:20:16Z

4

If you intend to copy source to destination, then you can make source a const & (there's no point in modifying it) and destination either a reference or a pointer.

void copyCard(card& destination, const card& source)
{
  destination = source;
}

int main()
{
  card card1, card2;

  card1.cvalue = 1000;
  card2.cvalue = 5;

  copyCard(card2, card1);
  cout << card2.cvalue << endl;
}

However, there's no reason for your copyCard function at all. You can copy card1 to card2 through simple assignment.

card2 = card1;

answered Sep 18, 2014 at 6:20

user3920237

Sign up to request clarification or add additional context in comments.

6 Comments

matt Over a year ago

i have to use pointers to copy these strings though in a different assignment and im trying to figure out how to do it. it gives me the error: cant assign const card to card

user3920237 Over a year ago

@matt What does the assignment require exactly?

matt Over a year ago

i have to create my own stringcopy function using pointers, essentially to copy this card struct to others and a "player struct" i omitted. i cant even figure out how to copy just the .cvalue with a pointer :(

user3920237 Over a year ago

@matt if your assignment requires memory management, check out https://stackoverflow.com/questions/4172722/what-is-the-rule-of-three.

juanchopanza Over a year ago

@mattmowris Either you misunderstood the assignment, or it is a bad assignment. There is no reason to use pointers to copy the struct in your example, but maybe you have to allocate an array of cards, or use dynamic allocation inside the card type. That would require user-provided copying code.

|

Collectives™ on Stack Overflow

creating custom" string " (struct) copy

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related