PHP error, outputs else when should be logging in

Question

Does anyone know whats wrong with this?, the else is echo'd even if credentials are correct

include("includes/dbconn.php");
// username and password sent from form 
$username=$_POST['username']; 
$password=$_POST['password']; 

$sql=("SELECT * FROM customers WHERE email ='.$username.' and password='.$password.'");
$result=mysql_query($sql);
$count=mysql_num_rows($result);

if($count==1){

    session_register("username");
    session_register("password"); 
    header("location:login_success.php");

} else {
    echo "Wrong Username or Password";
}

Please stop storing plain text passwords also this query is completely open to attack. — user557846
– user557846, Commented Sep 24, 2014 at 4:51

Jenz · Accepted Answer · 2014-09-24 04:49:25Z

2

The else section is executing because your query had failed. Remove the unnecessary brackets from the query. Also you are appending the values incorrectly. As you are enclosing the query within brackets, there is no need of appending it again.

So change your query

$sql=("SELECT * FROM customers WHERE email ='.$username.' and password='.$password.'");

to

$sql="SELECT * FROM customers WHERE email ='$username' and password='$password'";

answered Sep 24, 2014 at 4:49

Jenz

8,3718 gold badges50 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

user557846 Over a year ago

theses are the least of the problems here

user557846 Over a year ago

please don't this is the worst approach to take

benomatis Over a year ago

@Dagon what do you mean?

user557846 Over a year ago

plain text password no user variable sanitation - its security 101

William Francis Gomes Over a year ago

@Dagon i got your point brother, but this post solved the problem. So this deserves a upvote. Also now we can tell Ellis how to implement security issues. :)

|

Collectives™ on Stack Overflow

PHP error, outputs else when should be logging in

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related