PHP array being passed to javascript function not doing anything

Question

I have a php array that is being passed to a js function using "json_encode($array)", the problem is that when I click the button to trigger the function, nothing happens besides the page refreshing.

I think the problem might be the enclosing quotes, though I already tried changing from double to single and vice verse, no joy.

HTML:

 <button class="button1" 
  onclick="validateEncomenda('<?php echo json_encode($chosen_restaurant_addr);?>');
           return false;">Encomendar</button>

js:

function validateEncomenda(myarray){
   alert('Hello JS');
  }

if I echo the "json_encode($chosen_restaurant_addr)" I'm getting the right values in this format:

["ipsum lorem blah blah","Curabitur aliquam feugiat tellus"]

Any help or hint will be greatly appreciated.

Your double quotes in the json are closing the onclick event attribute. onclick="validateEncomenda('[" — David Sherret
– David Sherret, Commented Oct 7, 2014 at 14:26
Right, it seems to be a enclosing quotes problem. Can you post the computed value of json_encode($chosen_restaurant_addr) ? — daniloisr
– daniloisr, Commented Oct 7, 2014 at 14:26

Mike Brant · Accepted Answer · 2014-10-07 14:36:43Z

2

A better way to handle this would be to separate the onclick handling out from the HTML source. You could create a script like this:

var chosenResturant = <?php echo json_encode($chosen_restaurant_addr);?>;
document.getElementById('button1').onclick = function() {
    // no need to parse JSON here as we created an array literal above
    alert(chosenRestaurant.length);
    return false;
};

Note here that I am assuming that you add an id button1 to the element as the means for determining which elements gets the event handler. If you truly want to attach this behavior to all elements with the class name of button1, you would simply substitute getElementsByClassName('button1') instead of getElementById('button1')

edited Oct 7, 2014 at 14:36

answered Oct 7, 2014 at 14:31

Mike Brant

71.4k10 gold badges102 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

blue112 Over a year ago

You're missing quotes around the json ;)

Mike Brant Over a year ago

@blue112 I don't need quotes around it. I am defining an array literal (as I noted in my code sample).

blue112 Over a year ago

Oh yeah, it's json, it's working out of box in js, of course, my bad.

Mike Spider Over a year ago

Right the only problem is that i have all my JS in a separate file, and I'm using a function because for this case it works best as i have many other functions being called inside the validateEncomenda() function.

Mike Brant Over a year ago

@MichelFigueiredo You could still have the onclick handler function definition in a static js file and define the variable dynamically via PHP inside script tags (in essence what you are doing in the inline function call now).

|

blue112 · Accepted Answer · 2014-10-07 14:30:52Z

1

You should escape the quotes in the PHP output. Since HTML quote can't be escaped, rewrite it like this :

onclick='validateEncomenda("<?php echo addslashes(json_encode($chosen_restaurant_addr)); ?>"); return false;'>

answered Oct 7, 2014 at 14:30

blue112

57.2k3 gold badges52 silver badges58 bronze badges

1 Comment

Mike Spider Over a year ago

This works if i remove the "return false;" with the return false it tell me "invalid return" as a syntax error.

jewelnguyen8 · Accepted Answer · 2014-10-07 14:28:01Z

0

I think that you should add new attribute for the button: type="button"

answered Oct 7, 2014 at 14:28

jewelnguyen8

2593 silver badges16 bronze badges

Collectives™ on Stack Overflow

PHP array being passed to javascript function not doing anything

3 Answers 3

6 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related