modify if else condition in javascript

Question

var filterBy = window.location.search.substring(10);
if(filterBy !==""){
    if(filterBy ==='all'){
        $('#filterItems').find('[data-type]').show();
    }else{
        $('#filterBy li').removeClass('active');
        $('#filterBy').find('li[data-filter= "'+ filterBy + '"]').addClass('active');
        $('#filterItems').find('[data-type]').hide().end().find('[data-type*="' + filterBy + '"]').show();
    }
}

I want to make it optimized. filterBy==="" and filterBy === all. I feel its checking two times for condition. I want to have only condition check

Ricardo Lohmann · Accepted Answer · 2014-10-16 03:06:18Z

4

If filterBy equalt to "all", is not empty. So you don't need to check it too.

if (filterBy === 'all') {
    // your code here
} else if (filterBy !== '') {
    // your code here
}

answered Oct 16, 2014 at 3:06

Ricardo Lohmann

26.4k7 gold badges86 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jpcanamaque · Accepted Answer · 2014-10-16 03:08:04Z

0

You can simply do this.

if (filterBy === "" || filterBy === 'all'){
   // if condition is met
} else {
  // if condition is not met
}

answered Oct 16, 2014 at 3:08

jpcanamaque

1,0791 gold badge8 silver badges15 bronze badges

Collectives™ on Stack Overflow

modify if else condition in javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related