Javascript switch case - default option causing error

Question

I have code that defines behavior based on which input the code is handeling at that moment. The code looks something like:

switch(inputOption.name) {
 case 'NAME_1':
  switch(inputOption.type.toLowerCase()) {
    case 'radio':
      //some code
    case 'text':
      //some code
    ...
    case 'image':
      //some code

    default:
      return inputOption.value;
      break;
   }
  break;

  default:
    break;
 }

The code also includes some cascading cases. The default option causes the error. The error is listed as

    the default case is already defined

What is causing this error? The error shows up on the package folder, but the file shows no errors in the package view, but it shows errors when I open the file. I assumed it had something to do with the second default declaration, but it had no effect removing it.

Which browser is this? Because it's most certainly a bug, the labels should be local to their scope. — Niels Keurentjes
– Niels Keurentjes, Commented Oct 16, 2014 at 22:32
Not a browser error, it's showing as an error in eclipse itself. — user3334871
– user3334871, Commented Oct 16, 2014 at 22:33
Is it an error or a warning? I can understand the second (a missing break is usually a bug, or at least 'smelly code'), but not an error. That's also why the browsers don't complain. — Niels Keurentjes
– Niels Keurentjes, Commented Oct 16, 2014 at 22:34
It's listed as an error in eclipse. I'm pretty sure the browser isn't complaining, the submission is working as intended, I just don't understand why eclipse itself is telling me the default case has already been defined. — user3334871
– user3334871, Commented Oct 16, 2014 at 22:36

Maksym Kozlenko · Accepted Answer · 2014-10-16 22:31:05Z

0

You miss break statement for your outer case 'NAME_1'

switch(inputOption.name) {
 case 'NAME_1':
  switch(inputOption.type.toLowerCase()) {
    case 'radio':
      //some code
    case 'text':
      //some code
    ...
    case 'image':
      //some code

    default:
      return inputOption.value;
      break;
   }
   break; // <-------------------------------------------------- ADD THIS

  default:
    break;
 }

answered Oct 16, 2014 at 22:31

Maksym Kozlenko

10.4k2 gold badges69 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Niels Keurentjes Over a year ago

It may be a solution, but JS most definitely supports fallthrough in switching - his code should be allowed.

user3334871 Over a year ago

Sorry, I meant to be more clear, there is that line included in the file. I couldn't directly copy-and-paste, as this is work code.

user400654 Over a year ago

@MaksymKozlenko the original code works too, fyi. that's not the point.

Collectives™ on Stack Overflow

Javascript switch case - default option causing error

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related