PHP reports: unexpected T_VARIABLE

Question

I've got the following code:

class user {
            
  //URLs
  private static $signInURL = $_SERVER['DOCUMENT_ROOT'].'/?page=signin';
        
  ...
  ...
  ...

And I get an unexpected T_VARIABLE error.

How can I construct that url so it won't give me an error?

no it's not, edited so it more readable

Illes Peter
– Illes Peter

2010-04-22 13:51:06 +00:00
Commented Apr 22, 2010 at 13:51 — Illes Peter
– Illes Peter, Commented Apr 22, 2010 at 13:51

user253984 · Accepted Answer · 2010-04-22 13:50:44Z

4

You cannot use a variable there, you should move it into a method. It's bad style anyways as the class User has to know about $_SERVER.

If you really, really want it that way you could use:

private static $signInURL = '';

public static getSignInUrl()
{
  if (User::$signInUrl == '') User::$signInUrl = $_SERVER....;
  return User::$signInUrl;
}

I suggest using:

class User
{
  private static $signInUrl = '/signin';

  public static getSignInUrl($base)
  {
    return $base . User::$signInUrl;
  }
}

answered Apr 22, 2010 at 13:50

user253984

Sign up to request clarification or add additional context in comments.

1 Comment

Illes Peter Over a year ago

yes. your suggestion works ok and is an elegant solution as well. thanks for your help

Tower · Accepted Answer · 2010-04-22 14:21:02Z

1

You can not put variables as the value of class properties. Try,

class a
{
 private $signInURL;
 public function __construct()
 {
  $this->signInURL = $_SERVER['DOCUMENT_ROOT'].'/?page=signin';
 }
}

edited Apr 22, 2010 at 14:21

answered Apr 22, 2010 at 13:49

Tower

103k132 gold badges366 silver badges523 bronze badges

1 Comment

user253984 Over a year ago

You cannot use $this-> there because it's a static property. Also this will set the variable every time that class is created which might not be the intended behaviour (and the variable might be accessed without ever having created an instance of that class, i.e. by other static methods)

Collectives™ on Stack Overflow

PHP reports: unexpected T_VARIABLE

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related