JavaScript function onclick runs automatically

Question

i have this code in while loop in JavaScript. As you can see i am adding every loop to with ID page, another divs. Every div has onclick handler which can execute MyFunction with variable. My problem is that, my script onlick runs automatically when my page is loaded. But i need to run MyFunction only if i click on the div.

Code:

document.getElementById("page").innerHTML += "<div style='width:100px; float:left;' onclick='" + MyFunction(variable) + "'>" + AnotherVariable + "</div>";

Thank you

bob-fornal · Accepted Answer · 2014-12-03 21:18:13Z

3

You're a bit off ... try ...

document.getElementById("page").innerHTML += "<div style='width:100px; float:left;' onclick='MyFunction(" + variable + ")'>" + AnotherVariable + "</div>";

.. if you don't want the function to run.

In particular, look here:

"<div ... onclick='MyFunction(" + variable + ")'>"

UPDATE 1:

"Variable is string." Then, here's the modification:

document.getElementById("page").innerHTML += "<div style='width:100px; float:left;' onclick='MyFunction(\"" + variable + "\")'>" + AnotherVariable + "</div>";

edited Dec 3, 2014 at 21:18

answered Dec 3, 2014 at 20:01

bob-fornal

5,1205 gold badges34 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Jeff Watkins Over a year ago

Specifically, using MyFunction(variable) outside of quotes will run it as soon as the script block is rendered inserting the return value into the concatenated string, this is not we want in this case.

tomsk Over a year ago

Thank you, but i have new error --> Uncaught SyntaxError: Unexpected token ;... it is saying that is on system.html:1 and first line is <!DOCTYPE html> and there is no ";"

bob-fornal Over a year ago

Is variable numeric or a string ... might have to embed quotes if it is a string. use \" ...

bob-fornal Over a year ago

Fixed ... should have thought of that. Sorry.

Collectives™ on Stack Overflow

JavaScript function onclick runs automatically

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related