Javascript automaticly runs onclick function

Question

As I was making a gallery for a webpage I ran into a problem with js automatically running the (next_image) function, after some searching around I found out it was due to the () after the statement. however, I can not for the life of me figure out how else to get the clicked_id to the next_image function.

So my question is: how can I make it so that the function runs only after clicking the button while still sending the clicked_id?

function opencase(clicked_id) {
                document.getElementById("right_arrow").addEventListener("click", next_image(clicked_id));
            }
            function next_image(photoid){
                console.log(photoid);
                photoid++;
                document.getElementById("disp").setAttribute("src", "images/image"+photoid+".jpg");
                console.log(photoid);
            }

Any help will be greatly appreciated :D

another alternative to brk's answer is to have next_image return a function. function next_image(id) { return function() { /* use id here */ } } — rlemon
– rlemon, Commented Aug 2, 2019 at 15:06

brk · Accepted Answer · 2019-08-02 15:05:14Z

2

Instead of directly calling the function , call it from the addEventListener callback function

function opencase(clicked_id) {
  document.getElementById("right_arrow").addEventListener("click", function() {
    next_image(clicked_id)
  });
}

function next_image(photoid) {
  console.log(photoid);
  photoid++;
  document.getElementById("disp").setAttribute("src", "images/image" + photoid + ".jpg");
  console.log(photoid);
}

answered Aug 2, 2019 at 15:05

brk

50.3k10 gold badges59 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript automaticly runs onclick function

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related