Can creating complex objects in loop and calling methods in loop cause a stackOverflow exception?

Question

In my project there is a stackOVerFlow exception, they are creating objects inside for loop while iterating Map object.

I suspect that this complex object creation by calling other class methods inside loop is causing stackOverFlow.

Any thought on this would be greatly appreciated.

Below is the code in JAVA

 for (final Map.Entry<String, SomeBean> entry : actualBeanInfo.getPropertyMap().entrySet()) 
{
        final SomeBean property = entry.getValue();

        propName = property.getName();


        if (property.getGetter() == null) {
            continue;
        }

        if (ignoreProperty(property)) {
            continue;
        }

        Object value = SomeBeanUtilities.getBeanProperty(obj, property);
        value = SomeBeanUtilities.valueFromProperty(property, declaredType, null, value, context);
    }

I feel below two lines are causing error.

Object value = SomeBeanUtilities.getBeanProperty(obj, property);
        value = SomeBeanUtilities.valueFromProperty(property, declaredType, null, value, context);

Often stack overflows are caused by infinite recursion. What method is this code a part of? Is it possible that any of the methods you are calling call the method you are defining? — sprinter
– sprinter, Commented Feb 4, 2015 at 8:53
The message of the StackOverflowException shows a stack trace which gives a specific hint where the problem is. — Uli
– Uli, Commented Feb 4, 2015 at 8:54
I suggest trying to read the Stack of the StackOverflowError and trying to use the debugger to see why it happens. — Peter Lawrey
– Peter Lawrey, Commented Feb 4, 2015 at 8:56
It is exactly one line that calls the method causing the error. Without knowing the method... — laune
– laune, Commented Feb 4, 2015 at 10:38

Stephen C · Accepted Answer · 2015-02-05 11:20:22Z

1

Doing something in a loop (e.g. a while or for loop)` won't cause a stack overflow. Guaranteed. Loops don't cause new stack frames to be allocated.

Calling methods can, especially if the methods are directly or indirectly recursive. (You can get a stack overflow without recursion, but it is unlikely ... unless you have created threads with stacks that are too small.) The same applies to constructors.

However, knowing that doesn't get you very far. If you want to track down what is actually causing a stack overflow, you need to look at the stacktrace and the code of the methods that are involved. (The bodies of the methods ...)

I suspect that ...

Don't waste your time looking for bugs based on "suspicion". Gather and analyse the evidence and use that (and good old-fashioned logic) to direct your bug hunting.

edited Feb 5, 2015 at 11:20

answered Feb 4, 2015 at 10:49

Stephen C

723k95 gold badges849 silver badges1.3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Praveena DG Over a year ago

Does creating object inside loop has any memory overhead?? like this line in above code. Object value = SomeBeanUtilities.getBeanProperty(obj, property); i know from some of the stackOVerflow threads that it does not impact the performance but my question is about memory than performance. Declaring object outside the loop would be a better i feel so that same object will be getting assigned new values instead of a new object in every loop

Stephen C Over a year ago

"Does creating object inside loop has any memory overhead?". It has a bounded stack memory overhead ... unless the constructor body involves calling other methods or constructors. (Even constructor chaining is bounded.) Bounded stack memory usage means that stack overflow is highly unlikely.

Collectives™ on Stack Overflow

Can creating complex objects in loop and calling methods in loop cause a stackOverflow exception?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related