Cannot push certain string into to an array

Question

I am a newbie to javascript and made a mistake somewhere with the following code to find the string "Craig" and push it into a new array "Hits".

var text = "Hey, how are you \ doing? My name is Emily.\ My other friends       name is Craig. My friend Craig is learning JavaScript";
var myName = "Craig"
var hits = [];

for(var i = 0; i < text.length; i++){
if(text[i]=== "C"){
    for(var j = i; j < myName.length; j++ ){
       hits.push(j); 
    }
}
}

dReAmEr · Accepted Answer · 2015-02-23 04:13:33Z

1

Your for loop condition is not correct. Replace it with below. Use j < i + myName.length

for(var j = i; j < i+myName.length; j++ )

PS:- There are better way to do this, indexOf().

answered Feb 23, 2015 at 4:13

dReAmEr

7,2047 gold badges40 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

M3ghana · Accepted Answer · 2015-02-23 04:08:54Z

0

var text = "Hey, how are you \ doing? My name is Emily.\ My other    friends name is Craig. My friend Craig is learning JavaScript";

    var myName = "Craig"
    var hits = [];

    if (str.indexOf("Craig") > -1)
    {
       hits.push(myName);
    }

Here indexOf will return the position of the string match,if string is not found then the indexOf returns -1

answered Feb 23, 2015 at 4:08

M3ghana

1,3011 gold badge9 silver badges19 bronze badges

Collectives™ on Stack Overflow

Cannot push certain string into to an array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related