Replacing a string in url with another string

Question

Replacing imgur with filmot,

Input box - https://i.sstatic.net/Uguvn.jpg

Submit button

Once the submit is clicked in a new tab http://i.filmot.com/abcde.jpg has to open.

<html>
 <head>
 <title>input</title>
<script src="//code.jquery.com/jquery-1.11.2.min.js"></script>
<script>
function myFunction() {
    var res = str1.replace("imgur", "filmot");
    var win = window.open(res, '_blank');
    win.focus();
});
</script>
</head>
<body>
 <form>
 <input type=”text” id=”str1” />
<button onclick="myFunction()">Click</button>
</form>
</body>
</html>

The return code is not working. Please suggest.

Thanks :)

EDIT:

Here is solution code :)

<html>
 <head>
 <title>input</title>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<script>
function myFunction() {
  var str1 = document.getElementById('str1').value;
  var res = str1.replace("imgur", "filmot");
  document.getElementById('str1').value = res;
  var win = window.open(res, '_blank');
  win.focus();
}
</script>
</head>
<body>
<input type="text" id="str1" />
<button onclick="myFunction()">Click</button> 
</body>
</html>

Jai · Accepted Answer · 2015-03-11 08:03:10Z

3

Try this:

<script>
function myFunction() {
   var str1 = document.getElementById('str1').value; // add this
   var res = str1.replace("imgur", "filmot");
   var win = window.open(res, '_blank');
   win.focus();
} // <-----do a proper function closing.
</script>

Need to mention another thing may be the type=”text” id=”str1” quotes you are using, they are not the proper quotes. That should be changed to:

type="text" id="str1"

checkout the demo:

function myFunction() {
  var str1 = document.getElementById('str1').value;
  var res = str1.replace("imgur", "filmot");
  document.getElementById('str1').value = res;
  //window.open(res, '_blank');
  //win.focus();
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>


<input type="text" id="str1" value="http://i.imgur.com/abcde.jpg" />
<button onclick="myFunction()">Click</button>

edited Mar 11, 2015 at 8:03

answered Mar 11, 2015 at 7:55

Jai

74.8k12 gold badges77 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Vishnu Over a year ago

The snippet code works well! But the values I enter on input is dynamic so I pass an id with it to function.

Jai Over a year ago

@Vishnu that's fine! whatever url available in the text box your button will change the imgur to filmot.

Vishnu Over a year ago

After I click it changes to filmot for a second and changes back to imgur. I'm testing it as a html page.

Nagendra Nigade Over a year ago

@Vishnu Also check for your browser settings...Whether it's blocking popup ?

Jai Over a year ago

@Vishnu Its because of the form? Try adding a type="button" to the button or just remove the form tag.

|

scartag · Accepted Answer · 2015-03-11 07:59:07Z

0

Change this code.

var res = str1.replace("imgur", "filmot");

to

var res = $("#str1").val().replace("imgur", "filmot");

Your code wasn't getting the value from the textbox .. you were merely using a reference to the textbox.

Update

At the end of the function change }); to }

edited Mar 11, 2015 at 7:59

answered Mar 11, 2015 at 7:52

scartag

17.7k3 gold badges52 silver badges53 bronze badges

3 Comments

Vishnu Over a year ago

Hey thanks for the reply! I edited the code, but the new link is not opening in a new tab. Any idea where to edit?

scartag Over a year ago

@Vishnu remove the last parentheses and semi-colon ) just after the brace }.

Vishnu Over a year ago

Did that and still not opening :/

cнŝdk · Accepted Answer · 2015-03-11 08:21:35Z

0

Referring to the Opening a New Window tutorial:

To open a new window, you will need to use yet another ready-made JavaScript function. Here is what it looks like:

window.open('url to open','window name','attribute1,attribute2')

And I've Edited the function (added the window name') and it's working fine, replaces the url a,nd open it in a new tab:

function myFunction() {
  var str1 = document.getElementById('str1').value;
  var res = str1.replace("imgur", "filmot");
  window.open(res, 'new window', '_blank');
}

Here is the working DEMO.

answered Mar 11, 2015 at 8:21

cнŝdk

32.2k7 gold badges62 silver badges81 bronze badges

Comments

Sarah · Accepted Answer · 2015-03-11 08:24:27Z

0

Please try this :

<html>
 <head>
 <title>input</title>
<script src="//code.jquery.com/jquery-1.11.2.min.js"></script>
<script>
function myFunction() {
    var newString=str1.value;
    var res = newString.replace("imgur", "filmot");
    var win = window.open(res, '_blank');
    win.focus();
};
</script>
</head>
<body>
 <form>
 <input type="text" id="str1" value=""/>
<button onclick="myFunction();">Click</button>
</form>
</body>
</html>

answered Mar 11, 2015 at 8:24

Sarah

5253 silver badges14 bronze badges

Collectives™ on Stack Overflow

Replacing a string in url with another string

4 Answers 4

6 Comments

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

6 Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related