replace some character from string (url)

Question

I tried to remove some character from a string, but it failed and I don't know why.

This is the code

path='url("https://www.example.com/folder/next/another/myfilename.jpg")';

var file = path.split('/'); 
console.log('file is: '+file);
file = file[file.length-1];
console.log('file is: '+file);
file=file.replace('/[")(]/g',''); // try also replace('/[")(]','') failed
console.log('file is: '+file);
return file;

In the console I read

file is: url("https:,,www.example.com,folder,next,another,myfilename.jpg")
file is: myfilename.jpg")
file is: myfilename.jpg")

I don't understand why the "() charachters by the replace function won't replaced.

Thanks for helping and explaining!

Uncaught ReferenceError: path is not defined What is path? — CertainPerformance
– CertainPerformance, Commented Feb 20, 2019 at 6:27
maybe make '/[")(]/g' a regular expression, not a string by remove the quotes file.replace(/[")(]/g,'') — Nick Parsons
– Nick Parsons, Commented Feb 20, 2019 at 6:28
@ CertainPerformance you've right, ive update the post @ Jack Bashford at the end i want to have only the filename, so i must remove the path and the url("") — mikeD
– mikeD, Commented Feb 20, 2019 at 6:33
What do you want from the path string? Is "myfilename.jpg" what you'd like to have as a result? — sunsoft
– sunsoft, Commented Feb 20, 2019 at 6:34

A. Denis · Accepted Answer · 2019-02-20 06:51:21Z

2

Remove quotes in your regex:

function testFunction() {
    path='url("https://www.example.com/folder/next/another/myfilename.jpg")';

    var file = path.split('/'); 
    console.log('file is: '+file);
    file = file[file.length-1];
    console.log('file is: '+file);
    file=file.replace(/[")(]*/g, ''); 
    console.log('file is: '+file);
    return file;   
}
testFunction();

In console:

file is: url("https:,,www.example.com,folder,next,another,myfilename.jpg")
file is: myfilename.jpg")
file is: myfilename.jpg

Return value is "myfilename.jpg" now. Is it what youwhant?

answered Feb 20, 2019 at 6:51

A. Denis

5641 gold badge7 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

mikeD Over a year ago

yes, that was the problem, i was in faith, that the regex must be in quotes

Mohan M Over a year ago

Yeah.. right..i also find the issue.. But @mikeD u can use better approach for this problem. Something like path.split('/').pop().split('"')[0]; or path.split('"') console.log(file[1].split('/')[file[1].split('/').length -1]) or so on and so fourth...

Surender · Accepted Answer · 2019-02-20 06:51:20Z

1

Correct regex to use here would be /[()"]*/g instead of '/[")(]/g'

edited Feb 20, 2019 at 6:51

answered Feb 20, 2019 at 6:45

Surender

7575 silver badges12 bronze badges

2 Comments

mikeD Over a year ago

file=file.replace('/[()"]*/g',''); brings me the same result like in my post

Surender Over a year ago

Notice quotes around the regex. Hope you have already got that.

Community · Accepted Answer · 2020-06-20 09:12:55Z

1

const path = 'url("https://www.example.com/folder/next/another/myfilename.jpg")';

const filename = path.split('/').pop().split('"')[0];
console.log(filename);

Method

Split your string based on /
Get the last item with pop. This will give you myfilename.jpg")
Split again with "
Get the first item with array[0]. This will give you myfilename.jpg

Functions

Use Array.split to split your string based on a delimiter. The first time it's the /, the second time it's the " character
Use Array.pop to get (and remove) the last item in an array

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Feb 20, 2019 at 6:54

molamk

4,1161 gold badge15 silver badges22 bronze badges

Collectives™ on Stack Overflow

replace some character from string (url)

3 Answers 3

2 Comments

2 Comments

Method

Functions

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

2 Comments

Method

Functions

Comments

Your Answer

Sign up or log in

Post as a guest

Related