Read From a Binary file With FileInputStream

Question

I'm starting to learn Java I/O. I have a binary File with Integer data in it and I'm trying to read from it using FileInputStream and showing the content of the file on the console. It seems I'm not making the right approach, keep getting -1 witch means end of file. Here is my code.

File f=new File("sunday.dat");
FileInputStream fis=new FileInputStream(f);

try {
    while (true) {

        number=fis.read();
        System.out.println(number);

    }
} catch (EOFException e) {
    // TODO Auto-generated catch block
    e.printStackTrace();
}

fis.close();

@DasDas Irrelevant. The operation of that code is not version-dependent. — user207421
– user207421, Commented May 10, 2015 at 12:59
while (true) {...} will try to execute its code block infinitely. If you don't have any stop condition (or break/return/throw statements) then -1 will be printed all the time after you read file content. You need to rethink your loop. BTW if you want to read data as text use Reader. Streams are for binary data. — Pshemo
– Pshemo, Commented May 10, 2015 at 13:00
yes- but depends on he java version- we can tell him whats the best way to read the file — DasDas
– DasDas, Commented May 10, 2015 at 13:01
@DasDas He asked why he keeps getting -1. The answer to that is not version-dependent. — user207421
– user207421, Commented May 10, 2015 at 13:05

user207421 · Accepted Answer · 2015-05-10 12:59:14Z

2

It seems I'm not making the right approach, keep getting -1 which means end of file.

Exactly so. It means end of file. You should only get it once. You keep getting because you aren't testing for it and breaking out of the loop when you get it.

Instead you seem to be relying on catching EOFException, which is never thrown by that method.

answered May 10, 2015 at 12:59

user207421

312k45 gold badges324 silver badges493 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ricki Over a year ago

Which approach do you suggest to solve the problem the best way? change the while loop condition? or would you approach the problem in a different way, thanks a lot!

Collectives™ on Stack Overflow

Read From a Binary file With FileInputStream

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related