JSON Object Null

Question

I successfully deserialize JSON File and I'm getting the results but after the end of results I'm getting 'object not set to instance of an object` error

JSON File:

"radiant_team": {
          "team_name": "EHOME",
          "team_id": 4,
          "team_logo": 52122954231169668,
          "complete": true
        },
        "dire_team": {
          "team_name": "Team Secret",
          "team_id": 1838315,
          "team_logo": 543025270456493033,
          "complete": true

public partial class LiveLeagues
{
    public LiveGames Result { get; set; }
}
public class LiveGames
{
    public List<GameStats> games { get; set; }
    public int status { get; set; }
}
 public class GameStats
        {
            public List<BasePlayer> players { get; set; }
            public RadiantTeam radiant_team { get; set; }
            public DireTeam dire_team { get; set; }
        }

public class DireTeam
    {
        public string team_name { get; set; }
        public int team_id { get; set; }
        public object team_logo { get; set; }
        public bool complete { get; set; }
    }

public class RadiantTeam
    {
        public string team_name { get; set; }
        public int team_id { get; set; }
        public object team_logo { get; set; }
        public bool complete { get; set; }
    }

LiveLeagues.LiveLeagues liveGames = JsonConvert.DeserializeObject<LiveLeagues.LiveLeagues>(response.Content.ReadAsStringAsync().Result);

    foreach (var leagues in liveGames.Result.games)
        {
           MessageBox.Show(leagues.dire_team.team_id.ToString());
           MessageBox.Show(leagues.radiant_team.team_id.ToString());  
        }

I tried to iterate through the JSON and test if the values will show. I tested it on MessageBox.Show and I got the result "EHOME" and "Team Secret" but after that the error comes up 'object not set to instance of an object`

Please show the complete json and the value of liveGames.Result.games.Count. I guess there is an 'empty' game at the end of your json — Fortega
– Fortega, Commented Jun 5, 2015 at 7:01
response.Content.ReadAsStringAsync().Result that is most certainly wrong. — Jeff Mercado
– Jeff Mercado, Commented Jun 5, 2015 at 7:05
this is the JSON File i uploaded it on pastebin, can't post it on my post its too big pastebin.com/P8EPG41X — Nevi
– Nevi, Commented Jun 5, 2015 at 7:05
@JeffMercado how so? i have tried it on getting players name and id's it works just fine. — Nevi
– Nevi, Commented Jun 5, 2015 at 7:07
Your JSON File contains two livegames, and only the first one has a 'dire_team' and 'radiant_team' property. So for the second legues object, the dire_team will be null... — Fortega
– Fortega, Commented Jun 5, 2015 at 7:09

Fortega · Accepted Answer · 2015-06-05 07:18:56Z

1

When the json allows for games without the dire_team and/or radiant_team property, you should do null checks to make sure they are there:

foreach (var leagues in liveGames.Result.games){ 
  if(leagues.dire_team != null)
    MessageBox.Show(leagues.dire_team.team_id.ToString());
  else
    MessageBox.Show("no dire team for this game");

  if(leagues.radiant_team != null)      
     MessageBox.Show(leagues.radiant_team.team_id.ToString());  
  else
    MessageBox.Show("no radiant team for this game");
}

Or you could try using default values for these objects in the constructor of GameStats.

public class GameStats
    {
        public List<BasePlayer> players { get; set; }
        public RadiantTeam radiant_team { get; set; }
        public DireTeam dire_team { get; set; }

        public GameStats(){
          dire_team = new DireTeam();
          radiant_team = new RadiantTeam();
        }
    }

edited Jun 5, 2015 at 7:18

answered Jun 5, 2015 at 7:12

Fortega

19.7k15 gold badges78 silver badges115 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nevi Over a year ago

thank you for this so ill just null checks every property? is there any non tedious way to do this?

Fortega Over a year ago

@Nevi: see my edit. But this will not work for every json library. You should test if this works for you

Collectives™ on Stack Overflow

JSON Object Null

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related